Skip to content

Handle avg_pool2d with padding == 0 as no padding #10697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

3l1
Copy link
Contributor

@3l1 3l1 commented May 5, 2025

Differential Revision: D74117402

@3l1 3l1 requested a review from digantdesai as a code owner May 5, 2025 21:50
Copy link

pytorch-bot bot commented May 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10697

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 75e0496 with merge base e60958a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74117402

@3l1
Copy link
Contributor Author

3l1 commented May 5, 2025

@pytorchbot label "topic: not user facing"

3l1 added a commit to 3l1/executorch that referenced this pull request May 5, 2025
Summary: Pull Request resolved: pytorch#10697

Differential Revision: D74117402
@3l1 3l1 force-pushed the export-D74117402 branch from 0b4e0c1 to d1f7ac6 Compare May 5, 2025 21:53
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74117402

3l1 added a commit to 3l1/executorch that referenced this pull request May 5, 2025
Summary: Pull Request resolved: pytorch#10697

Differential Revision: D74117402
@3l1 3l1 force-pushed the export-D74117402 branch from d1f7ac6 to ad993a2 Compare May 5, 2025 22:09
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74117402

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping to unblock, left a comment on the diff

Summary: Pull Request resolved: pytorch#10697

Differential Revision: D74117402
@3l1 3l1 force-pushed the export-D74117402 branch from ad993a2 to 75e0496 Compare May 6, 2025 21:35
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74117402

@limintang limintang self-requested a review May 7, 2025 23:41
@facebook-github-bot facebook-github-bot merged commit 4863988 into pytorch:main May 8, 2025
87 checks passed
@zingo zingo added the module: arm Issues related to arm backend label May 8, 2025
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
Differential Revision: D74117402

Pull Request resolved: pytorch#10697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: arm Issues related to arm backend topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants