-
Notifications
You must be signed in to change notification settings - Fork 607
Convert the unit test from java to kotlin #10702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10702
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 44e263e with merge base 578358b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@@ -34,6 +35,9 @@ android { | |||
resources.srcDirs += [ 'src/androidTest/resources' ] | |||
} | |||
} | |||
kotlinOptions { | |||
jvmTarget = '17' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now we have
compileOptions {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
}
is 1.8 possible? Otherwise we make everything 17?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should make it to use 1.8 for kotlin compiler as well for the compatibility, will update.
@pytorchbot label "topic: not user facing" |
|
Looks like all CI jobs succeeded now. |
### Summary This change converts the unit test from java to kotlin. ### Test plan ./gradlew :executorch_android:testDebugUnitTest --------- Co-authored-by: Haiting Pu <[email protected]>
Summary
This change converts the unit test from java to kotlin.
Test plan
./gradlew :executorch_android:testDebugUnitTest