Improvements to gen_sample_etrecord #1073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50579104 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50579104 |
vmpuri
pushed a commit
to vmpuri/executorch-1
that referenced
this pull request
Oct 27, 2023
Summary: Pull Request resolved: pytorch#1073 Various improvements to the gen_sample_etrecord script. - Enable users to generate an etrecord from any of the sample models - Output files to /tmp instead of the working directory, provide a CLI option for this - Clean up imports and add type hints Differential Revision: D50579104 fbshipit-source-id: 40ee8297dba3bbe6f0bada5e819863b08e77862d
vmpuri
force-pushed
the
export-D50579104
branch
from
d010e62 to
7fec943
Compare
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1073
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 62e5a46 with merge base 251801e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D50579104 |
vmpuri
pushed a commit
to vmpuri/executorch-1
that referenced
this pull request
Oct 27, 2023
Summary: Pull Request resolved: pytorch#1073 Various improvements to the gen_sample_etrecord script. - Enable users to generate an etrecord from any of the sample models - Output files to /tmp instead of the working directory, provide a CLI option for this - Clean up imports and add type hints Reviewed By: Jack-Khuu Differential Revision: D50579104 fbshipit-source-id: 5ac5ebe981d37aaa94835f9faf71a9f883f55f1e
vmpuri
force-pushed
the
export-D50579104
branch
from
7fec943 to
4c0066f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50579104 |
vmpuri
pushed a commit
to vmpuri/executorch-1
that referenced
this pull request
Oct 27, 2023
Summary: Pull Request resolved: pytorch#1073 Various improvements to the gen_sample_etrecord script. - Enable users to generate an etrecord from any of the sample models - Output files to /tmp instead of the working directory, provide a CLI option for this - Clean up imports and add type hints Reviewed By: Jack-Khuu Differential Revision: D50579104 fbshipit-source-id: a574a4723a0a2345336d61c1d7a62d669c2e3953
vmpuri
force-pushed
the
export-D50579104
branch
from
4c0066f to
d434d90
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50579104 |
vmpuri
pushed a commit
to vmpuri/executorch-1
that referenced
this pull request
Oct 27, 2023
Summary: Pull Request resolved: pytorch#1073 Various improvements to the gen_sample_etrecord script. - Enable users to generate an etrecord from any of the sample models - Output files to /tmp instead of the working directory, provide a CLI option for this - Clean up imports and add type hints Reviewed By: Jack-Khuu Differential Revision: D50579104 fbshipit-source-id: d04c2f9b81352cfb8bc3cbadc5e9c82cc9200643
vmpuri
force-pushed
the
export-D50579104
branch
from
d434d90 to
6b3ac30
Compare
Summary: This script is useful to generate a sample ETRecord from the example models provided in the repo. This should help users explore the features of the ETrecord without needing to first export a .pte model. Differential Revision: https://internalfb.com/D50521582 fbshipit-source-id: abf3702f1c4acc83844de7806b441b776927f01e
Summary: Pull Request resolved: pytorch#1073 Various improvements to the gen_sample_etrecord script. - Enable users to generate an etrecord from any of the sample models - Output files to /tmp instead of the working directory, provide a CLI option for this - Clean up imports and add type hints Reviewed By: Jack-Khuu Differential Revision: D50579104 fbshipit-source-id: 574f612b0c8a880ea96dda99431198c393d9bb2f
|
This pull request was exported from Phabricator. Differential Revision: D50579104 |
vmpuri
force-pushed
the
export-D50579104
branch
from
6b3ac30 to
62e5a46
Compare
|
This pull request has been merged in 7814dd7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Various improvements to the gen_sample_etrecord script.
Differential Revision: D50579104