Skip to content

to make TIE quantized conv operator to fall back to hifi quantized conv op instead of cpu op for shapes not supported by the TIE kernel. #10770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

wl1026sun
Copy link
Contributor

Summary: some quantized conv shape are not supported by the TIE operator, right now the tie op will fall back to CPU op. with this diff would fall back to use the operator from the hifi non-tie backend instead.

Differential Revision: D74337713

@wl1026sun wl1026sun requested a review from tarun292 as a code owner May 8, 2025 05:02
Copy link

pytorch-bot bot commented May 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10770

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2a4a73f with merge base 5ad676d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74337713

@wl1026sun
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@wl1026sun wl1026sun force-pushed the export-D74337713 branch from ac2c959 to 6375850 Compare May 8, 2025 22:25
wl1026sun added a commit to wl1026sun/executorch that referenced this pull request May 8, 2025
…nv op instead of cpu op for shapes not supported by the TIE kernel. (pytorch#10770)

Summary:

some quantized conv shape are not supported by the TIE operator, right now the tie op will fall back to CPU op. with this diff would fall back to use the operator from the hifi non-tie backend instead.

Reviewed By: zonglinpeng

Differential Revision: D74337713
wl1026sun added a commit to wl1026sun/executorch that referenced this pull request May 8, 2025
…nv op instead of cpu op for shapes not supported by the TIE kernel. (pytorch#10770)

Summary:

some quantized conv shape are not supported by the TIE operator, right now the tie op will fall back to CPU op. with this diff would fall back to use the operator from the hifi non-tie backend instead.

Reviewed By: zonglinpeng

Differential Revision: D74337713
@wl1026sun wl1026sun force-pushed the export-D74337713 branch from 6375850 to b7ba593 Compare May 8, 2025 22:25
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74337713

…nv op instead of cpu op for shapes not supported by the TIE kernel. (pytorch#10770)

Summary:
Pull Request resolved: pytorch#10770

some quantized conv shape are not supported by the TIE operator, right now the tie op will fall back to CPU op. with this diff would fall back to use the operator from the hifi non-tie backend instead.

Reviewed By: zonglinpeng

Differential Revision: D74337713
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74337713

@wl1026sun wl1026sun force-pushed the export-D74337713 branch from b7ba593 to 2a4a73f Compare May 8, 2025 22:31
@facebook-github-bot facebook-github-bot merged commit 6e3cb79 into pytorch:main May 9, 2025
86 of 88 checks passed
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
…nv op instead of cpu op for shapes not supported by the TIE kernel.

Differential Revision: D74337713

Pull Request resolved: pytorch#10770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants