Add etdump to android #10889
Merged
Add etdump to android #10889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JNI not exposed yet. Need to think about API
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10889
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 Cancelled JobsAs of commit b839911 with merge base 3032398 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
kirklandsign
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
kirklandsign
requested review from
jathu,
larryliu0820,
GregoryComer,
swolchok and
tarun292
as code owners
kirklandsign
commented
May 19, 2025
scripts/build_android_library.sh
Outdated
| @@ -40,6 +40,8 @@ build_android_native_library() { | |||
| -DANDROID_PLATFORM=android-26 \ | |||
| -DBUILD_TESTING=OFF \ | |||
| -DEXECUTORCH_ENABLE_LOGGING=ON \ | |||
| -DEXECUTORCH_BUILD_DEVTOOLS=ON \ | |||
| -DEXECUTORCH_ENABLE_EVENT_TRACER=ON \ | |||
There was a problem hiding this comment.
Depend on "${EXECUTORCH_ANDROID_PROFILING:-OFF}"
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
added
release notes: none
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shoumikhin
approved these changes
May 19, 2025
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
kirklandsign
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a temporary API to generate etdump for benchmark app