Pybindings Module is more flexible with non_const set ups #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48583639 |
Summary: Pull Request resolved: pytorch/executorch#98 title Differential Revision: https://internalfb.com/D48576051 fbshipit-source-id: 6ad2d696635737043ae3ff6097601597f2c98478
Summary: Pull Request resolved: pytorch/executorch#97 unused so deleting Differential Revision: https://internalfb.com/D48576223 fbshipit-source-id: 761270610694853687dbe5527aa9c014bff7d1c8
Summary: Pull Request resolved: pytorch/executorch#109 Made the module handle models with more then one non_const buffer level, and made it allocate the needed memory dynamically rather then relying on static constants which historically have needed to be updated a ton. Differential Revision: D48583639 fbshipit-source-id: 6f2fe6b3a235d3f8f57c185f5331deceaf40aeec
|
This pull request was exported from Phabricator. Differential Revision: D48583639 |
JacobSzwejbka
force-pushed
the
export-D48583639
branch
from
96e601a to
8e83f7d
Compare
|
This pull request has been merged in f4ed04f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Made the module handle models with more then one non_const buffer level, and made it allocate the needed memory dynamically rather then relying on static constants which historically have needed to be updated a ton.
Differential Revision: D48583639