Skip to content

Arm backend: Fix TOSA 1.0 node visitor for sum #10908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Conversation

per
Copy link
Collaborator

@per per commented May 15, 2025

Summary

Fixes serialization for sum.dim_IntList node visitor as well as some rescale handling issues.

Test plan

Tested with internal and external CI.

cc @digantdesai @freddan80 @zingo @oscarandersson8218

@per per requested a review from zingo May 15, 2025 14:56
@per per requested a review from digantdesai as a code owner May 15, 2025 14:56
@per per added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels May 15, 2025
Copy link

pytorch-bot bot commented May 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10908

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 24acdb2 with merge base d069d65 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 15, 2025
Fixes serialization for sum.dim_IntList node visitor
as well as some rescale handling issues.

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I13838a7eb3742c227fc5038ec32026271716eb25
@zingo zingo merged commit 12af535 into pytorch:main May 16, 2025
179 of 182 checks passed
@per per deleted the fixup_1_0 branch May 16, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants