Skip to content

Define PYTHON_EXECUTABLE only once in cmake #10911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 15, 2025

Summary

There is no need to redefine this over and over again. Do it once at the root. Lmk if I'm missing something:

$ rg -t cmake -g '!examples' "resolve_python"
$ rg -t cmake -g '!examples' "NOT PYTHON_EXECUTABLE"
$ rg -t cmake -g '!examples' "python3"
$ rg -t cmake -g '!examples' "python\s"

Test plan

CI

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels May 15, 2025
Copy link

pytorch-bot bot commented May 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10911

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Pending, 1 Unrelated Failure

As of commit b0a2cc6 with merge base 9f6c0f2 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 15, 2025
@jathu jathu force-pushed the jathu/cmake-python-sweep branch from 2d38bc9 to 36490b4 Compare May 15, 2025 16:48
@jathu jathu marked this pull request as ready for review May 15, 2025 17:52
@jathu jathu force-pushed the jathu/cmake-python-sweep branch from 36490b4 to ae05691 Compare May 15, 2025 18:11
@jathu jathu force-pushed the jathu/cmake-python-sweep branch from ae05691 to b0a2cc6 Compare May 15, 2025 21:47
@jathu jathu merged commit 78fe7ee into main May 15, 2025
200 of 203 checks passed
@jathu jathu deleted the jathu/cmake-python-sweep branch May 15, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants