Skip to content

Make test_force_quant_dequant_fusion use GraphBuilder. #10926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

eigen-k
Copy link
Contributor

@eigen-k eigen-k commented May 15, 2025

Summary: Use GraphBuilder to create the model for unit testing.

Differential Revision: D74841541

@eigen-k eigen-k requested a review from tarun292 as a code owner May 15, 2025 22:29
Copy link

pytorch-bot bot commented May 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10926

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 26357dd with merge base cb3eba0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 15, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74841541

eigen-k added a commit to eigen-k/executorch that referenced this pull request May 16, 2025
Summary:

Use GraphBuilder to create the model for unit testing.

Differential Revision: D74841541
@eigen-k eigen-k force-pushed the export-D74841541 branch from b23a639 to 62c7604 Compare May 16, 2025 17:24
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74841541

@eigen-k eigen-k added the release notes: none Do not include this in the release notes label May 16, 2025
op=exir_ops.edge.quantized_decomposed.dequantize_per_tensor.default,
args=(permute, 4.5, 6, 0, 127, torch.int8),
)
builder.output(dequant)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: use a variable for readability

Suggested change
builder.output(dequant)
builder.output(dequant)
graph_module = builder.get_graph_module()


graph_module = FuseQuantDequantToRequantizePass(
force_quant_dequant_fusion=True
)(graph_module).graph_module
)(builder.get_graph_module()).graph_module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
)(builder.get_graph_module()).graph_module
)(graph_module).graph_module

eigen-k added a commit to eigen-k/executorch that referenced this pull request May 19, 2025
Summary:

Use GraphBuilder to create the model for unit testing.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D74841541
@eigen-k eigen-k force-pushed the export-D74841541 branch from 62c7604 to 2551eef Compare May 19, 2025 16:52
eigen-k added a commit to eigen-k/executorch that referenced this pull request May 19, 2025
Summary:

Use GraphBuilder to create the model for unit testing.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D74841541
@eigen-k eigen-k force-pushed the export-D74841541 branch from 2551eef to 559a472 Compare May 19, 2025 16:58
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74841541

eigen-k added a commit to eigen-k/executorch that referenced this pull request May 19, 2025
Summary:
Pull Request resolved: pytorch#10926

Use GraphBuilder to create the model for unit testing.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D74841541
@eigen-k eigen-k force-pushed the export-D74841541 branch from 559a472 to 174c695 Compare May 19, 2025 16:59
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74841541

eigen-k added a commit to eigen-k/executorch that referenced this pull request May 19, 2025
Summary:
Pull Request resolved: pytorch#10926

Use GraphBuilder to create the model for unit testing.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D74841541
@eigen-k eigen-k force-pushed the export-D74841541 branch from 174c695 to 321b109 Compare May 19, 2025 17:09
eigen-k added a commit to eigen-k/executorch that referenced this pull request May 19, 2025
Summary:

Use GraphBuilder to create the model for unit testing.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D74841541
@eigen-k eigen-k force-pushed the export-D74841541 branch from 321b109 to c9e67b0 Compare May 19, 2025 19:10
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74841541

eigen-k added a commit to eigen-k/executorch that referenced this pull request May 19, 2025
Summary:

Use GraphBuilder to create the model for unit testing.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D74841541
@eigen-k eigen-k force-pushed the export-D74841541 branch from c9e67b0 to 7b1ef5e Compare May 19, 2025 23:17
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74841541

eigen-k added a commit to eigen-k/executorch that referenced this pull request May 19, 2025
Summary:
Pull Request resolved: pytorch#10926

Use GraphBuilder to create the model for unit testing.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D74841541
@eigen-k eigen-k force-pushed the export-D74841541 branch from 7b1ef5e to 9796716 Compare May 19, 2025 23:22
eigen-k added a commit to eigen-k/executorch that referenced this pull request May 19, 2025
Summary:

Use GraphBuilder to create the model for unit testing.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D74841541
@eigen-k eigen-k force-pushed the export-D74841541 branch from 9796716 to 3d49adc Compare May 19, 2025 23:40
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74841541

eigen-k added a commit to eigen-k/executorch that referenced this pull request May 19, 2025
Summary:

Use GraphBuilder to create the model for unit testing.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D74841541
@eigen-k eigen-k force-pushed the export-D74841541 branch from 3d49adc to 5e9e7d1 Compare May 19, 2025 23:44
Summary:
Pull Request resolved: pytorch#10926

Use GraphBuilder to create the model for unit testing.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D74841541
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74841541

@eigen-k eigen-k force-pushed the export-D74841541 branch from 5e9e7d1 to 26357dd Compare May 19, 2025 23:47
@facebook-github-bot facebook-github-bot merged commit fff7b3c into pytorch:main May 20, 2025
88 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants