Copy executorch codegen from pytorch torchgen to executorch repo #10939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10939
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit 70c8e96 with merge base 9cce48d ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74865579 |
facebook-github-bot
force-pushed
the
export-D74865579
branch
from
a43b5d1 to
8346e00
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74865579 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D74865579 |
larryliu0820
added a commit
that referenced
this pull request
May 16, 2025
) Summary: Pull Request resolved: #10939 This is a long due cleanup. When `gen_executorch.py` was added to `torchgen` ExecuTorch was not open sourced yet. Now is a good time to put the codegen scripts to where they belong. Differential Revision: D74865579
larryliu0820
force-pushed
the
export-D74865579
branch
from
8346e00 to
3f0a395
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74865579 |
larryliu0820
added a commit
that referenced
this pull request
May 16, 2025
) Summary: Pull Request resolved: #10939 This is a long due cleanup. When `gen_executorch.py` was added to `torchgen` ExecuTorch was not open sourced yet. Now is a good time to put the codegen scripts to where they belong. Differential Revision: D74865579
larryliu0820
force-pushed
the
export-D74865579
branch
from
3f0a395 to
6c87b6d
Compare
manuelcandales
approved these changes
May 16, 2025
|
This pull request was exported from Phabricator. Differential Revision: D74865579 |
larryliu0820
added a commit
that referenced
this pull request
May 16, 2025
) Summary: Pull Request resolved: #10939 This is a long due cleanup. When `gen_executorch.py` was added to `torchgen` ExecuTorch was not open sourced yet. Now is a good time to put the codegen scripts to where they belong. Reviewed By: manuelcandales Differential Revision: D74865579
larryliu0820
force-pushed
the
export-D74865579
branch
from
6c87b6d to
3734181
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74865579 |
larryliu0820
added a commit
that referenced
this pull request
May 16, 2025
) Summary: Pull Request resolved: #10939 This is a long due cleanup. When `gen_executorch.py` was added to `torchgen` ExecuTorch was not open sourced yet. Now is a good time to put the codegen scripts to where they belong. Reviewed By: manuelcandales Differential Revision: D74865579
larryliu0820
force-pushed
the
export-D74865579
branch
from
3734181 to
581a5df
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74865579 |
larryliu0820
added a commit
that referenced
this pull request
May 16, 2025
) Summary: Pull Request resolved: #10939 This is a long due cleanup. When `gen_executorch.py` was added to `torchgen` ExecuTorch was not open sourced yet. Now is a good time to put the codegen scripts to where they belong. Reviewed By: manuelcandales Differential Revision: D74865579
larryliu0820
force-pushed
the
export-D74865579
branch
from
581a5df to
2f65588
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74865579 |
larryliu0820
added a commit
that referenced
this pull request
May 16, 2025
) Summary: Pull Request resolved: #10939 This is a long due cleanup. When `gen_executorch.py` was added to `torchgen` ExecuTorch was not open sourced yet. Now is a good time to put the codegen scripts to where they belong. Reviewed By: manuelcandales Differential Revision: D74865579
larryliu0820
force-pushed
the
export-D74865579
branch
from
2f65588 to
2bf30ce
Compare
larryliu0820
force-pushed
the
export-D74865579
branch
from
342e9b9 to
12532bd
Compare
larryliu0820
added
the
release notes: none
|
This pull request was exported from Phabricator. Differential Revision: D74865579 |
larryliu0820
added a commit
that referenced
this pull request
May 16, 2025
) Summary: Pull Request resolved: #10939 This is a long due cleanup. When `gen_executorch.py` was added to `torchgen` ExecuTorch was not open sourced yet. Now is a good time to put the codegen scripts to where they belong. Reviewed By: manuelcandales Differential Revision: D74865579
larryliu0820
force-pushed
the
export-D74865579
branch
from
12532bd to
7262707
Compare
) Summary: Pull Request resolved: #10939 This is a long due cleanup. When `gen_executorch.py` was added to `torchgen` ExecuTorch was not open sourced yet. Now is a good time to put the codegen scripts to where they belong. Reviewed By: manuelcandales Differential Revision: D74865579
|
This pull request was exported from Phabricator. Differential Revision: D74865579 |
larryliu0820
force-pushed
the
export-D74865579
branch
from
7262707 to
70c8e96
Compare
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
May 19, 2025
Differential Revision: D74865579 Pull Request resolved: pytorch#10939
facebook-github-bot
pushed a commit
that referenced
this pull request
May 22, 2025
Summary: As a follow up to #10939, we need to add the same coverage to this code. Differential Revision: D75236020
facebook-github-bot
pushed a commit
that referenced
this pull request
May 22, 2025
Summary: As a follow up to #10939, we need to add the same coverage to this code. Reviewed By: kirklandsign, manuelcandales Differential Revision: D75236020
facebook-github-bot
pushed a commit
that referenced
this pull request
May 22, 2025
Summary: As a follow up to #10939, we need to add the same coverage to this code. Reviewed By: kirklandsign, manuelcandales Differential Revision: D75236020
larryliu0820
added a commit
that referenced
this pull request
May 23, 2025
…rchgen Summary: As titled, after #10939 we are able to use `executorch.codegen` APIs instead of `torchgen.executorch` APIs. This PR moves `gen_oplist.py` to use the new `executorch.codgen` API. Reviewed By: kirklandsign Differential Revision: D75307480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is a long due cleanup. When
gen_executorch.pywas added totorchgenExecuTorch was not open sourced yet. Now is a good time to put the codegen scripts to where they belong.Differential Revision: D74865579