Skip to content

Arm backend: Adjust AvgPool2d padding when window is not divisible by stride #10972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025

Conversation

tom-arm
Copy link
Collaborator

@tom-arm tom-arm commented May 19, 2025

  • AvgPool2dVisitor will adjust the padding so the pooling window is divisible by the stride
  • Improve tests in test_max_pool.py

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

… stride

* AvgPool2dVisitor will adjust the padding so the pooling window is divisible by the stride
* Improve tests in test_max_pool.py

Signed-off-by: Tom Allsop <[email protected]>
Change-Id: I068f025a961a4671ad6727ff156cbad87bec2c08
@tom-arm tom-arm requested a review from digantdesai as a code owner May 19, 2025 14:09
Copy link

pytorch-bot bot commented May 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10972

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 796dbad with merge base b73f9d5 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 19, 2025
@tom-arm tom-arm added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels May 19, 2025
@zingo
Copy link
Collaborator

zingo commented May 19, 2025

Rebased after Arm test fixes

@zingo zingo added the release notes: none Do not include this in the release notes label May 20, 2025
@zingo
Copy link
Collaborator

zingo commented May 20, 2025

test fails unrelated

@zingo zingo merged commit 08dfe52 into pytorch:main May 20, 2025
181 of 184 checks passed
@tom-arm tom-arm deleted the adjust_avgpool2d_padding branch May 22, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants