Guard against existing cache when configuring options #10984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathu
added
module: build/install
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10984
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 98c535a with merge base cb3eba0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jathu
force-pushed
the
jathu/guard-against-cache
branch
2 times, most recently
from
98823c6 to
f32db20
Compare
jathu
force-pushed
the
jathu/guard-against-cache
branch
from
f32db20 to
98c535a
Compare
kirklandsign
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@kirklandsign came across an issue where if the existing
cmake-outfolder was not deleted, it would just use the existing cache. We want to override this and always use whatever the current value is.Test plan
unittest + CI
cc @larryliu0820