Skip to content

Fix urls #11004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025
Merged

Fix urls #11004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f31e6f
Fix urls
shoumikhin May 20, 2025
f852ad3
Merge branch 'main' into fix-urls-2
shoumikhin May 20, 2025
830ddf9
Update test_gather_benchmark_configs.py
shoumikhin May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .ci/scripts/tests/test_gather_benchmark_configs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ def test_skip_disabled_configs(self):
"mv3": [
self.gather_benchmark_configs.DisabledConfig(
config_name="disabled_config1",
github_issue="https://github.com/org/repo/issues/123",
github_issue="https://github.com/org/repo/issues/123", # @lint-ignore
),
self.gather_benchmark_configs.DisabledConfig(
config_name="disabled_config2",
github_issue="https://github.com/org/repo/issues/124",
github_issue="https://github.com/org/repo/issues/124", # @lint-ignore
),
]
},
Expand All @@ -84,7 +84,9 @@ def test_skip_disabled_configs(self):
self.assertIn("enabled_config2", result)

def test_disabled_configs_have_github_links(self):
github_issue_regex = re.compile(r"https://github\.com/.+/.+/issues/\d+")
github_issue_regex = re.compile(
r"https://github\.com/.+/.+/issues/\d+" # @lint-ignore
)

for (
model_name,
Expand Down
1 change: 0 additions & 1 deletion .github/scripts/label_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ def get_last_page_num_from_header(header: Any) -> int:
# rel="next", <https://api.github.com/repositories/65600975/labels?per_page=100&page=3>; rel="last"
link_info = header["link"]
# Docs does not specify that it should be present for projects with just few labels
# And https://github.com/malfet/deleteme/actions/runs/7334565243/job/19971396887 it's not the case
if link_info is None:
return 1
prefix = "&page="
Expand Down
16 changes: 8 additions & 8 deletions .github/scripts/test_extract_benchmark_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ def get_mock_happy_flow_content(app_type: str = "IOS_APP"):
"name": "Syslog",
"type": "DEVICE_LOG",
"extension": "syslog",
"url": "https://job_arn_1_device_log",
"s3_url": "https://job_arn_1/test-workflow1/1/syslog.syslog",
"url": "https://job_arn_1_device_log", # @lint-ignore
"s3_url": "https://job_arn_1/test-workflow1/1/syslog.syslog", # @lint-ignore
"app_type": app_type,
"job_name": "job_arn_1_name",
"os": "14",
Expand All @@ -55,8 +55,8 @@ def get_mock_happy_flow_content(app_type: str = "IOS_APP"):
"name": "Customer Artifacts",
"type": "CUSTOMER_ARTIFACT",
"extension": "zip",
"url": "https://job_arn_1_customer_artifact",
"s3_url": "https://job_arn_1_customer_artifact1",
"url": "https://job_arn_1_customer_artifact", # @lint-ignore
"s3_url": "https://job_arn_1_customer_artifact1", # @lint-ignore
"app_type": app_type,
"job_name": "job_arn_1_device_name",
"os": "14",
Expand All @@ -68,8 +68,8 @@ def get_mock_happy_flow_content(app_type: str = "IOS_APP"):
"name": "Syslog",
"type": "DEVICE_LOG",
"extension": "syslog",
"url": "https://job_arn_1_device_log",
"s3_url": "https://job_arn_1/test-workflow1/1/syslog.syslog",
"url": "https://job_arn_1_device_log", # @lint-ignore
"s3_url": "https://job_arn_1/test-workflow1/1/syslog.syslog", # @lint-ignore
"app_type": app_type,
"job_name": "job_arn_2_name",
"os": "14",
Expand All @@ -94,8 +94,8 @@ def get_mock_happy_flow_content(app_type: str = "IOS_APP"):
"name": "Customer Artifacts",
"type": "CUSTOMER_ARTIFACT",
"extension": "zip",
"url": "https://job_arn_1_customer_artifact",
"s3_url": "https://job_arn_1_customer_artifact1",
"url": "https://job_arn_1_customer_artifact", # @lint-ignore
"s3_url": "https://job_arn_1_customer_artifact1", # @lint-ignore
"app_type": app_type,
"job_name": "job_arn_2_name",
"os": "14",
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/trymerge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1964,7 +1964,7 @@ def check_for_sev(org: str, project: str, skip_mandatory_checks: bool) -> None:
response = cast(
Dict[str, Any],
gh_fetch_json_list(
"https://api.github.com/search/issues",
"https://api.github.com/search/issues", # @lint-ignore
params={"q": f'repo:{org}/{project} is:open is:issue label:"ci: sev"'},
),
)
Expand Down
2 changes: 1 addition & 1 deletion examples/qualcomm/qaihub_scripts/utils/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ If users are interested in well-known applications, [Qualcomm AI HUB](https://ai
### Target Model

* Consider using [virtual environment](https://app.aihub.qualcomm.com/docs/hub/getting_started.html) for AI HUB scripts to prevent package conflict against ExecuTorch. Please finish the [installation section](https://app.aihub.qualcomm.com/docs/hub/getting_started.html#installation) before proceeding following steps.
* Take [QuickSRNetLarge-Quantized](https://aihub.qualcomm.com/models/quicksrnetlarge_quantized?searchTerm=quantized) as an example, please [install](https://huggingface.co/qualcomm/QuickSRNetLarge-Quantized#installation) package as instructed.
* Take [QuickSRNetLarge](https://aihub.qualcomm.com/iot/models/quicksrnetlarge) as an example, please [install](https://huggingface.co/qualcomm/QuickSRNetLarge-Quantized#installation) package as instructed.
* Create workspace and export pre-built model library:
```bash
mkdir $MY_WS && cd $MY_WS
Expand Down
Loading