Skip to content

Add GELU support to XNNPACK #11006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 28, 2025
Merged

Add GELU support to XNNPACK #11006

merged 6 commits into from
May 28, 2025

Conversation

leafs1
Copy link
Contributor

@leafs1 leafs1 commented May 20, 2025

Summary

Add GELU support to XNNPACK

Test plan

Wrote tests and asserted that xnnpack delegate would run for GELU op

@leafs1 leafs1 requested review from digantdesai and mcr229 as code owners May 20, 2025 18:39
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11006

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit f20e42a with merge base 3351ecc (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2025
@leafs1
Copy link
Contributor Author

leafs1 commented May 20, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label May 20, 2025
mcr229
mcr229 reviewed May 20, 2025
View reviewed changes
.gitignore Outdated
backends/apple/coreml/executorchcoreml.cpython-312-darwin.so
/cmake_wrapper.sh
/data/
/devtools/bundled_program/serialize/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these seem a little suspicious? maybe @shoumikhin or @larryliu0820 can comment on some of these, i'm guessing they come from the --editable path.

Do you mind putting this up as a separate PR? I see it's a separate commit, so would be a nice time to try out ghstack

Copy link
Contributor Author

@leafs1 leafs1 May 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When building locally all of these directories/files got generated, I just wanted to add them to gitignore so i can add files to git easier. I'll make a separate pr

mcr229
mcr229 reviewed May 20, 2025
View reviewed changes
backends/xnnpack/operators/op_gelu.py Outdated


@register_node_visitor
class LogVisitor(NodeVisitor):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong name?

@leafs1 leafs1 merged commit 18e5eca into pytorch:main May 28, 2025
93 of 96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcr229 mcr229 mcr229 approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leafs1 @mcr229 @facebook-github-bot