Use GraphBuilder in unit tests for ops removal. #11010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11010
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 065e7b4 with merge base df5e7df ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75026207 |
eigen-k
added
release notes: none
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
|
This pull request was exported from Phabricator. Differential Revision: D75026207 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Pull Request resolved: pytorch#11010 Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
zonglinpeng
approved these changes
May 20, 2025
zonglinpeng
reviewed
May 20, 2025
| @@ -247,6 +244,7 @@ def forward(self, x): | |||
| count_node(graph_module, exir_ops.edge.aten.view_copy.default), 2 | |||
| ) | |||
|
|
|||
| # Already covered | |||
There was a problem hiding this comment.
are these commented needed?
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
|
This pull request was exported from Phabricator. Differential Revision: D75026207 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Pull Request resolved: pytorch#11010 Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
|
This pull request was exported from Phabricator. Differential Revision: D75026207 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Pull Request resolved: pytorch#11010 Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
|
This pull request was exported from Phabricator. Differential Revision: D75026207 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D75026207 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Pull Request resolved: pytorch#11010 Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
|
This pull request was exported from Phabricator. Differential Revision: D75026207 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
|
This pull request was exported from Phabricator. Differential Revision: D75026207 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 20, 2025
Summary: Pull Request resolved: pytorch#11010 Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 21, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 21, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 21, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 22, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
|
This pull request was exported from Phabricator. Differential Revision: D75026207 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 22, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 22, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 22, 2025
Summary: Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
Summary: Pull Request resolved: pytorch#11010 Use GraphBuilder in unit tests for ops removal. Reviewed By: zonglinpeng Differential Revision: D75026207
|
This pull request was exported from Phabricator. Differential Revision: D75026207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use GraphBuilder in unit tests for ops removal.
Reviewed By: zonglinpeng
Differential Revision: D75026207