Skip to content

migrate convert/prepare to torchao #11015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2025
Merged

migrate convert/prepare to torchao #11015

merged 3 commits into from
May 21, 2025

Conversation

metascroy
Copy link
Contributor

This PR migrates the convert/prepare pt2e APIs to torchao, and adds a linter to prevent using the APIs from torch.ao.

It also migrates the example quantizer to fully use torchao APIs.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11015

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 50d6d7f with merge base 5866c19 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2025
@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@metascroy metascroy added the release notes: none Do not include this in the release notes label May 20, 2025
jerryzh168
jerryzh168 reviewed May 20, 2025
View reviewed changes
backends/example/example_quantizer.py
from torchao.quantization.pt2e.graph_utils import find_sequential_partitions
from torchao.quantization.pt2e.observer import HistogramObserver, MinMaxObserver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to import from pt2e directly? or do you feel specifying graph_utils / observer are better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like graph_utils/observer personally

But people can use top-level too if they want

@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@metascroy metascroy force-pushed the migrate-pt2e-top-level branch from 8e2f769 to 50d6d7f Compare May 20, 2025 23:09
@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 6a8d286 into main May 21, 2025
197 checks passed
@facebook-github-bot facebook-github-bot deleted the migrate-pt2e-top-level branch May 21, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

@jathu jathu Awaiting requested review from jathu

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@GregoryComer GregoryComer Awaiting requested review from GregoryComer GregoryComer is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@iseeyuan iseeyuan Awaiting requested review from iseeyuan

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@tarun292 tarun292 Awaiting requested review from tarun292

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

@mcr229 mcr229 Awaiting requested review from mcr229 mcr229 is a code owner

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

@SS-JIA SS-JIA Awaiting requested review from SS-JIA SS-JIA is a code owner

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel is a code owner

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metascroy @facebook-github-bot @jerryzh168