Skip to content

Add NS_NOESCAPE attributes to Tensor getters #11032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

Add NS_NOESCAPE attributes to Tensor getters #11032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dc82b9
Add NS_NOESCAPE attributes to Tensor getters
shoumikhin May 21, 2025
05909c6
Update ExecuTorchTensor.mm
shoumikhin May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extension/apple/ExecuTorch/Exported/ExecuTorchTensor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ __attribute__((deprecated("This API is experimental.")))
* - the total number of elements,
* - and the data type.
*/
- (void)bytesWithHandler:(void (^)(const void *pointer, NSInteger count, ExecuTorchDataType dataType))handler
- (void)bytesWithHandler:(NS_NOESCAPE void (^)(const void *pointer, NSInteger count, ExecuTorchDataType dataType))handler
NS_SWIFT_NAME(bytes(_:));

/**
Expand All @@ -186,7 +186,7 @@ __attribute__((deprecated("This API is experimental.")))
* - the total number of elements,
* - and the data type.
*/
- (void)mutableBytesWithHandler:(void (^)(void *pointer, NSInteger count, ExecuTorchDataType dataType))handler
- (void)mutableBytesWithHandler:(NS_NOESCAPE void (^)(void *pointer, NSInteger count, ExecuTorchDataType dataType))handler
NS_SWIFT_NAME(mutableBytes(_:));

/**
Expand Down
4 changes: 2 additions & 2 deletions extension/apple/ExecuTorch/Exported/ExecuTorchTensor.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,12 @@ - (NSInteger)count {
return _tensor->numel();
}

- (void)bytesWithHandler:(void (^)(const void *pointer, NSInteger count, ExecuTorchDataType type))handler {
- (void)bytesWithHandler:(NS_NOESCAPE void (^)(const void *pointer, NSInteger count, ExecuTorchDataType type))handler {
ET_CHECK(handler);
handler(_tensor->unsafeGetTensorImpl()->data(), self.count, self.dataType);
}

- (void)mutableBytesWithHandler:(void (^)(void *pointer, NSInteger count, ExecuTorchDataType dataType))handler {
- (void)mutableBytesWithHandler:(NS_NOESCAPE void (^)(void *pointer, NSInteger count, ExecuTorchDataType dataType))handler {
ET_CHECK(handler);
handler(_tensor->unsafeGetTensorImpl()->mutable_data(), self.count, self.dataType);
}
Expand Down
Loading