Skip to content

Arm backend: Add constant ops unittests. #11038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented May 21, 2025

Adds unittests for eye, ones and zeros.

These ops are supported by the ComputeConstantOpsAOT pass, add unittests for coverage. This exposes an edge case bug similar as for the clone, where a partition with one single constant op results in an empty network.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Adds unittests for eye, ones and zeros.

These ops are supported by the ComputeConstantOpsAOT pass,
add unittests for coverage. This exposes an edge case bug similar
as for the clone, where a partion with one single constant op
results in an empty network.

Signed-off-by: Adrian Lundell <[email protected]>
Change-Id: Ieabf8bc7b28ad887f0238c1e889332dc663cb7d6
@AdrianLundell AdrianLundell added ciflow/trunk topic: not user facing module: arm Issues related to arm backend release notes: none Do not include this in the release notes labels May 21, 2025
Copy link

pytorch-bot bot commented May 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11038

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit 1fc1bb4 with merge base d8c26ee (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2025
@zingo
Copy link
Collaborator

zingo commented May 21, 2025

Unrelated fails
pull / unittest-editable / macos / macos-job (pull_request)

@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm and removed module: arm Issues related to arm backend labels May 21, 2025
@zingo zingo merged commit d892b66 into pytorch:main May 21, 2025
183 of 187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants