Add CMake preset for LLM #11052
Merged
Add CMake preset for LLM #11052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: By default turn on custom ops, optimized kernels, xnnpack. For macOS/iOS turn on coreml and MPS. Test Plan: Rely on CI jobs. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11052
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit e2e330d with merge base d892b66 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
added
the
release notes: llm
jathu
reviewed
May 21, 2025
| -DEXECUTORCH_BUILD_XNNPACK="$XNNPACK" \ | ||
| -DEXECUTORCH_BUILD_MPS="$MPS" \ | ||
| -DEXECUTORCH_BUILD_COREML="$COREML" \ | ||
| retry cmake --preset llm \ |
Summary: By default turn on custom ops, optimized kernels, xnnpack. For macOS/iOS turn on coreml and MPS. Test Plan: Rely on CI jobs. [ghstack-poisoned]
Summary: By default turn on custom ops, optimized kernels, xnnpack. For macOS/iOS turn on coreml and MPS. Test Plan: Rely on CI jobs. [ghstack-poisoned]
Summary: By default turn on custom ops, optimized kernels, xnnpack. For macOS/iOS turn on coreml and MPS. Test Plan: Rely on CI jobs. [ghstack-poisoned]
jathu
reviewed
May 22, 2025
| @@ -152,21 +152,11 @@ which "${PYTHON_EXECUTABLE}" | |||
| cmake_install_executorch_libraries() { | |||
| echo "Installing libexecutorch.a, libextension_module.so, libportable_ops_lib.a" | |||
| rm -rf cmake-out | |||
| retry cmake \ | |||
| retry cmake --preset llm \ | |||
| -DCMAKE_INSTALL_PREFIX=cmake-out \ | |||
There was a problem hiding this comment.
This can be deleted too, since it's the default
Summary: By default turn on custom ops, optimized kernels, xnnpack. For macOS/iOS turn on coreml and MPS. Test Plan: Rely on CI jobs. [ghstack-poisoned]
larryliu0820
merged commit a36e122
into
gh/larryliu0820/64/base
190 of 192 checks passed
larryliu0820
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
larryliu0820
added a commit
that referenced
this pull request
May 22, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11052 by @larryliu0820 ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/larryliu0820/64/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/64/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/64/orig @diff-train-skip-merge Co-authored-by: Mengwei Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: By default turn on custom ops, optimized kernels, xnnpack. For
macOS/iOS turn on coreml and MPS.
Test Plan: Rely on CI jobs.