Skip to content

Mark native Swift extension public #11087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025
Merged

Mark native Swift extension public #11087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a275ed
Mark native Swift extension public
shoumikhin May 23, 2025
e516195
Merge branch 'main' into shoumikhin-patch-1
shoumikhin May 23, 2025
ee0f680
Update ExecuTorch+Tensor.swift
shoumikhin May 23, 2025
a435364
Update TensorTest.swift
shoumikhin May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions extension/apple/ExecuTorch/Exported/ExecuTorch+Tensor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,40 +11,40 @@
/// A protocol that types conform to in order to be used as tensor element types.
/// Provides the mapping from the Swift type to the underlying `DataType`.
@available(*, deprecated, message: "This API is experimental.")
protocol Scalar {
public protocol Scalar {
/// The `DataType` corresponding to this scalar type.
static var dataType: DataType { get }
}

@available(*, deprecated, message: "This API is experimental.")
extension UInt8: Scalar { static var dataType: DataType { .byte } }
extension UInt8: Scalar { public static var dataType: DataType { .byte } }
@available(*, deprecated, message: "This API is experimental.")
extension Int8: Scalar { static var dataType: DataType { .char } }
extension Int8: Scalar { public static var dataType: DataType { .char } }
@available(*, deprecated, message: "This API is experimental.")
extension Int16: Scalar { static var dataType: DataType { .short } }
extension Int16: Scalar { public static var dataType: DataType { .short } }
@available(*, deprecated, message: "This API is experimental.")
extension Int32: Scalar { static var dataType: DataType { .int } }
extension Int32: Scalar { public static var dataType: DataType { .int } }
@available(*, deprecated, message: "This API is experimental.")
extension Int64: Scalar { static var dataType: DataType { .long } }
extension Int64: Scalar { public static var dataType: DataType { .long } }
@available(*, deprecated, message: "This API is experimental.")
extension Int: Scalar { static var dataType: DataType { .long } }
extension Int: Scalar { public static var dataType: DataType { .long } }
@available(*, deprecated, message: "This API is experimental.")
extension Float: Scalar { static var dataType: DataType { .float } }
extension Float: Scalar { public static var dataType: DataType { .float } }
@available(*, deprecated, message: "This API is experimental.")
extension Double: Scalar { static var dataType: DataType { .double } }
extension Double: Scalar { public static var dataType: DataType { .double } }
@available(*, deprecated, message: "This API is experimental.")
extension Bool: Scalar { static var dataType: DataType { .bool } }
extension Bool: Scalar { public static var dataType: DataType { .bool } }
@available(*, deprecated, message: "This API is experimental.")
extension UInt16: Scalar { static var dataType: DataType { .uInt16 } }
extension UInt16: Scalar { public static var dataType: DataType { .uInt16 } }
@available(*, deprecated, message: "This API is experimental.")
extension UInt32: Scalar { static var dataType: DataType { .uInt32 } }
extension UInt32: Scalar { public static var dataType: DataType { .uInt32 } }
@available(*, deprecated, message: "This API is experimental.")
extension UInt64: Scalar { static var dataType: DataType { .uInt64 } }
extension UInt64: Scalar { public static var dataType: DataType { .uInt64 } }
@available(*, deprecated, message: "This API is experimental.")
extension UInt: Scalar { static var dataType: DataType { .uInt64 } }
extension UInt: Scalar { public static var dataType: DataType { .uInt64 } }

@available(*, deprecated, message: "This API is experimental.")
extension Tensor {
public extension Tensor {
/// Calls the closure with a typed, immutable buffer pointer over the tensor’s elements.
///
/// - Parameter body: A closure that receives an `UnsafeBufferPointer<T>` bound to the tensor’s data.
Expand Down
2 changes: 1 addition & 1 deletion extension/apple/ExecuTorch/__tests__/TensorTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ class TensorTest: XCTestCase {
let tensor = data.withUnsafeMutableBytes {
Tensor(bytesNoCopy: $0.baseAddress!, shape: [2, 3], dataType: .float)
}
let array: [Float] = try tensor.withUnsafeBytes { Array($0) }
let array = try tensor.withUnsafeBytes([Float].init)
XCTAssertEqual(array, data)
}

Expand Down
Loading