Skip to content

Create an iOS and macOS preset #11111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Create an iOS and macOS preset #11111

merged 1 commit into from
May 23, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 23, 2025

Summary

  • Create a macos, ios, and ios-simulator preset
  • The flags are copied from scripts/build_apple_frameworks.sh. In an upcoming PR, I will replace that command with this preset

Test plan

CI +

$ cmake --preset macos && cmake --build cmake-out -j $(sysctl -n hw.ncpu)
$ cmake --preset ios && cmake --build cmake-out -j $(sysctl -n hw.ncpu)
$ cmake --preset ios-simulator && cmake --build cmake-out -j $(sysctl -n hw.ncpu)

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels May 23, 2025
Copy link

pytorch-bot bot commented May 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11111

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 6 Pending, 2 Unrelated Failures

As of commit 9ace4de with merge base f2fb351 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2025
@jathu jathu requested a review from shoumikhin May 23, 2025 20:35
@jathu jathu marked this pull request as ready for review May 23, 2025 20:42
@jathu jathu force-pushed the jathu/apple-preset branch from 1dcc44f to 9ace4de Compare May 23, 2025 20:54
@jathu jathu merged commit 18ce8a8 into main May 23, 2025
91 of 93 checks passed
@jathu jathu deleted the jathu/apple-preset branch May 23, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants