check for overflow in calculate_nbytes #11217

JacobSzwejbka · 2025-05-29T16:54:40Z

Summary: Got a fuzzer error around overflow here

Differential Revision: D75544079

pytorch-bot · 2025-05-29T16:54:44Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11217

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit b4b35e2 with merge base 5ef38d3 ():

CANCELLED JOB - The following job was cancelled. Please retry:

pull / unittest-editable / macos / macos-job (gh)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-05-29T16:54:51Z

This pull request was exported from Phabricator. Differential Revision: D75544079

Summary: Got a fuzzer error around overflow here Differential Revision: D75544079

facebook-github-bot · 2025-05-29T17:35:12Z

This pull request was exported from Phabricator. Differential Revision: D75544079

Summary: Pull Request resolved: pytorch#11217 Got a fuzzer error around overflow here Differential Revision: D75544079

Summary: Got a fuzzer error around overflow here Differential Revision: D75544079

facebook-github-bot · 2025-05-29T20:00:08Z

This pull request was exported from Phabricator. Differential Revision: D75544079

Summary: Pull Request resolved: pytorch#11217 Got a fuzzer error around overflow here Differential Revision: D75544079

Summary: Got a fuzzer error around overflow here Differential Revision: D75544079

lucylq

Thanks for adding this! Could you also make the same changes to tensor_layout?

executorch/runtime/core/tensor_layout.cpp

Line 19 in 14c3b31

Result<size_t> calculate_nbytes(

runtime/executor/method_meta.cpp

facebook-github-bot · 2025-05-30T17:13:50Z

@JacobSzwejbka has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: Got a fuzzer error around overflow here Reviewed By: lucylq Differential Revision: D75544079 Pulled By: JacobSzwejbka

facebook-github-bot · 2025-05-30T17:17:21Z

This pull request was exported from Phabricator. Differential Revision: D75544079

Summary: Got a fuzzer error around overflow here Reviewed By: lucylq Differential Revision: D75544079 Pulled By: JacobSzwejbka

facebook-github-bot · 2025-05-30T17:18:10Z

This pull request was exported from Phabricator. Differential Revision: D75544079

Summary: Got a fuzzer error around overflow here Reviewed By: lucylq Differential Revision: D75544079 Pulled By: JacobSzwejbka

facebook-github-bot · 2025-06-02T23:44:40Z

This pull request was exported from Phabricator. Differential Revision: D75544079

Summary: Got a fuzzer error around overflow here Pull Request resolved: pytorch#11217 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: lucylq Differential Revision: D75544079 Pulled By: JacobSzwejbka

Summary: Got a fuzzer error around overflow here Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: lucylq Differential Revision: D75544079 Pulled By: JacobSzwejbka

facebook-github-bot · 2025-06-03T04:26:20Z

This pull request was exported from Phabricator. Differential Revision: D75544079

Summary: Got a fuzzer error around overflow here Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: lucylq Differential Revision: D75544079 Pulled By: JacobSzwejbka

facebook-github-bot · 2025-06-03T16:52:51Z

This pull request was exported from Phabricator. Differential Revision: D75544079

facebook-github-bot · 2025-06-03T16:57:12Z

This pull request was exported from Phabricator. Differential Revision: D75544079

Summary: Got a fuzzer error around overflow here Pull Request resolved: pytorch#11217 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: lucylq Differential Revision: D75544079 Pulled By: JacobSzwejbka

swolchok · 2025-06-03T17:15:50Z

runtime/executor/method_meta.cpp

+    // Check for overflow
+    ET_CHECK(sizes[i] == 0 || n / sizes[i] == prev_n);


is it necessary to perform a division here? could we check n >= prev_n instead?

Ah ok no it doesnt work. I can give a counter example.

To get the numbers smaller lets say Im accumulating in uint16_t and Im taking the product of int8_t::max

n: 127 prev_n: 1

n: 16129 prev_n: 127

n: 16767 prev_n: 16129 (overflowed at 65535 from logical value 2048383)

hmm. I'm tempted to ask if we should just import c10/util/safe_numerics.h (which, note to self, requires llvmMathExtra.h) instead of doing division then. it is annoying that it only has 64-bit safe_multiplies functions, but we could add a size_t-based one (in executorch for now if you don't want to wait for pin bump, followed by adding it in pytorch, getting a pin bump, and deleting the executorch one).

runtime/executor/method_meta.cpp

Summary: Got a fuzzer error around overflow here Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: lucylq Differential Revision: D75544079 Pulled By: JacobSzwejbka

facebook-github-bot · 2025-06-03T17:45:25Z

This pull request was exported from Phabricator. Differential Revision: D75544079

Summary: Got a fuzzer error around overflow here Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: lucylq Differential Revision: D75544079 Pulled By: JacobSzwejbka

facebook-github-bot · 2025-06-03T17:58:13Z

This pull request was exported from Phabricator. Differential Revision: D75544079

Summary: Got a fuzzer error around overflow here Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: lucylq Differential Revision: D75544079 Pulled By: JacobSzwejbka

facebook-github-bot · 2025-06-03T18:21:19Z

This pull request was exported from Phabricator. Differential Revision: D75544079

Summary: Got a fuzzer error around overflow here Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: lucylq Differential Revision: D75544079 Pulled By: JacobSzwejbka

facebook-github-bot · 2025-06-03T18:51:46Z

This pull request was exported from Phabricator. Differential Revision: D75544079

JacobSzwejbka requested review from lucylq and swolchok as code owners May 29, 2025 16:54

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels May 29, 2025

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request May 29, 2025

check for overflow in calculate_nbytes (pytorch#11217)

5d3972e

Summary: Got a fuzzer error around overflow here Differential Revision: D75544079

JacobSzwejbka force-pushed the export-D75544079 branch from 434c823 to 5d3972e Compare May 29, 2025 17:31

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request May 29, 2025

check for overflow in calculate_nbytes (pytorch#11217)

32eef53

Summary: Pull Request resolved: pytorch#11217 Got a fuzzer error around overflow here Differential Revision: D75544079

JacobSzwejbka force-pushed the export-D75544079 branch from 5d3972e to 32eef53 Compare May 29, 2025 17:35

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request May 29, 2025

check for overflow in calculate_nbytes (pytorch#11217)

2daf3a0

Summary: Got a fuzzer error around overflow here Differential Revision: D75544079

JacobSzwejbka force-pushed the export-D75544079 branch from 32eef53 to 2daf3a0 Compare May 29, 2025 19:57

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request May 29, 2025

check for overflow in calculate_nbytes (pytorch#11217)

9831a5f

Summary: Pull Request resolved: pytorch#11217 Got a fuzzer error around overflow here Differential Revision: D75544079

JacobSzwejbka force-pushed the export-D75544079 branch from 2daf3a0 to 9831a5f Compare May 29, 2025 20:00

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request May 29, 2025

check for overflow in calculate_nbytes (pytorch#11217)

7351b90

Summary: Got a fuzzer error around overflow here Differential Revision: D75544079

JacobSzwejbka force-pushed the export-D75544079 branch from 9831a5f to 7351b90 Compare May 29, 2025 20:08

lucylq approved these changes May 29, 2025

View reviewed changes

runtime/executor/method_meta.cpp Outdated Show resolved Hide resolved

runtime/executor/method_meta.cpp Outdated Show resolved Hide resolved

JacobSzwejbka added the release notes: none Do not include this in the release notes label May 30, 2025

JacobSzwejbka force-pushed the export-D75544079 branch from 3f3b171 to aca6a6d Compare May 30, 2025 17:17

JacobSzwejbka force-pushed the export-D75544079 branch from aca6a6d to 1c3dcd0 Compare May 30, 2025 17:18

JacobSzwejbka force-pushed the export-D75544079 branch from 1c3dcd0 to e0b8b5e Compare May 30, 2025 18:40

JacobSzwejbka force-pushed the export-D75544079 branch from e8c8ad9 to 0ba6715 Compare June 2, 2025 23:39

JacobSzwejbka force-pushed the export-D75544079 branch from 0ba6715 to 83e4f30 Compare June 2, 2025 23:44

JacobSzwejbka force-pushed the export-D75544079 branch from 83e4f30 to f96f246 Compare June 3, 2025 04:26

JacobSzwejbka force-pushed the export-D75544079 branch from f96f246 to 0b65bb0 Compare June 3, 2025 16:52

JacobSzwejbka force-pushed the export-D75544079 branch from 0b65bb0 to aecdbbc Compare June 3, 2025 16:52

JacobSzwejbka force-pushed the export-D75544079 branch from aecdbbc to 83f6030 Compare June 3, 2025 16:57

swolchok reviewed Jun 3, 2025

View reviewed changes

JacobSzwejbka force-pushed the export-D75544079 branch from 83f6030 to bbbf9b3 Compare June 3, 2025 17:45

JacobSzwejbka force-pushed the export-D75544079 branch from bbbf9b3 to 656d28e Compare June 3, 2025 17:57

JacobSzwejbka force-pushed the export-D75544079 branch from 656d28e to 179b1f3 Compare June 3, 2025 18:21

check for overflow in calculate_nbytes (pytorch#11217)

b4b35e2

Summary: Got a fuzzer error around overflow here Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: lucylq Differential Revision: D75544079 Pulled By: JacobSzwejbka

JacobSzwejbka force-pushed the export-D75544079 branch from 179b1f3 to b4b35e2 Compare June 3, 2025 18:51

lucylq merged commit 93b1a0c into pytorch:main Jun 4, 2025
96 of 98 checks passed

JacobSzwejbka mentioned this pull request Jun 4, 2025

Import and extend c10/util/safe_numerics.h #11370

Open

		// Check for overflow
		ET_CHECK(sizes[i] == 0 \|\| n / sizes[i] == prev_n);

check for overflow in calculate_nbytes #11217

check for overflow in calculate_nbytes #11217

Uh oh!

Conversation

JacobSzwejbka commented May 29, 2025

Uh oh!

pytorch-bot bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11217

❌ 1 Cancelled Job

Uh oh!

facebook-github-bot commented May 29, 2025

Uh oh!

facebook-github-bot commented May 29, 2025

Uh oh!

facebook-github-bot commented May 29, 2025

Uh oh!

lucylq left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented May 30, 2025

Uh oh!

facebook-github-bot commented May 30, 2025

Uh oh!

facebook-github-bot commented May 30, 2025

Uh oh!

facebook-github-bot commented Jun 2, 2025

Uh oh!

facebook-github-bot commented Jun 3, 2025

Uh oh!

facebook-github-bot commented Jun 3, 2025

Uh oh!

facebook-github-bot commented Jun 3, 2025

Uh oh!

swolchok Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

JacobSzwejbka Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

JacobSzwejbka Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

swolchok Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

JacobSzwejbka Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

facebook-github-bot commented Jun 3, 2025

Uh oh!

facebook-github-bot commented Jun 3, 2025

Uh oh!

facebook-github-bot commented Jun 3, 2025

Uh oh!

facebook-github-bot commented Jun 3, 2025

Uh oh!

Uh oh!

Uh oh!

pytorch-bot bot commented May 29, 2025 •

edited

Loading

JacobSzwejbka Jun 3, 2025 •

edited

Loading