Arm backend: Remove special host build of flatcc #11278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a workaround as host version of flattcc was not generated from the build as it should and you got the target version. Later when flattcc was needed on the host it was the wrong version and you got an error. Now this has been solved in the project and flattcc is only build for the host so there is no need to force a special build like this anymore. Signed-off-by: Zingo Andersen <[email protected]> Change-Id: I274c17bc0ac9e4445a623400afef428f92aabcb4
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11278
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit d46a6a0 with merge base d4906e2 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
added
ciflow/trunk
release notes: none
|
Unrelated fail |
|
@jathu looks good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was a workaround as host version of flattcc was not generated from the build as it should and you got the target version. Later when flattcc was needed on the host it was the wrong version and you got an error.
Now this has been solved in the project and flattcc is only build for the host so there is no need to force a special build like this anymore.
Test plan
Tested in local build and on GitHub
cc @digantdesai @freddan80 @per @oscarandersson8218