Skip to content

Update coreml transformer with Rope and RMSNorm original definitions #11583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

YIWENX14
Copy link
Contributor

Summary: Keep the module in sync with https://github.com/pytorch/executorch/tree/main/examples/models/llama

Differential Revision: D76468703

Copy link

pytorch-bot bot commented Jun 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11583

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6dd2a2c with merge base 0d244f9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76468703

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76468703

YIWENX14 added a commit to YIWENX14/executorch that referenced this pull request Jun 12, 2025
@YIWENX14
Copy link
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Jun 12, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76468703

YIWENX14 added a commit to YIWENX14/executorch that referenced this pull request Jun 12, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76468703

@facebook-github-bot facebook-github-bot merged commit 4a14fdd into pytorch:main Jun 12, 2025
102 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants