Skip to content

Introduce extension/llm/export_llm #11746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

jackzhxng
Copy link
Contributor

Summary: Introduces frontend of export_llm in extension/llm, while keeping most of the code still in examples/models/llama as a first step.

Differential Revision: D76781745

Copy link

pytorch-bot bot commented Jun 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11746

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 38e1edc with merge base 7bd15b9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11746

Introduces frontend of export_llm in extension/llm, while keeping most of the code still in examples/models/llama as a first step.

Differential Revision: D76781745
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11746

Introduces frontend of export_llm in extension/llm, while keeping most of the code still in examples/models/llama as a first step.

Differential Revision: D76781745
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11746

Introduces frontend of export_llm in extension/llm, while keeping most of the code still in examples/models/llama as a first step.

Differential Revision: D76781745
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11746

Introduces frontend of export_llm in extension/llm, while keeping most of the code still in examples/models/llama as a first step.

Reviewed By: larryliu0820

Differential Revision: D76781745
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11746

Introduces frontend of export_llm in extension/llm, while keeping most of the code still in examples/models/llama as a first step.

Reviewed By: larryliu0820

Differential Revision: D76781745
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11746

Introduces frontend of export_llm in extension/llm, while keeping most of the code still in examples/models/llama as a first step.

Reviewed By: larryliu0820

Differential Revision: D76781745
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11746

Introduces frontend of export_llm in extension/llm, while keeping most of the code still in examples/models/llama as a first step.

Reviewed By: larryliu0820

Differential Revision: D76781745
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11746

Introduces frontend of export_llm in extension/llm, while keeping most of the code still in examples/models/llama as a first step.

Reviewed By: larryliu0820

Differential Revision: D76781745
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

2 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11746

Introduces frontend of export_llm in extension/llm, while keeping most of the code still in examples/models/llama as a first step.

Reviewed By: larryliu0820

Differential Revision: D76781745
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jun 18, 2025
Summary:
Pull Request resolved: pytorch#11746

Introduces frontend of export_llm in extension/llm, while keeping most of the code still in examples/models/llama as a first step.

Reviewed By: larryliu0820

Differential Revision: D76781745
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

Summary:
Pull Request resolved: pytorch#11746

Introduces frontend of export_llm in extension/llm, while keeping most of the code still in examples/models/llama as a first step.

Reviewed By: larryliu0820

Differential Revision: D76781745
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76781745

@facebook-github-bot facebook-github-bot merged commit 44d2643 into pytorch:main Jun 18, 2025
96 of 104 checks passed
@mergennachin mergennachin self-requested a review June 18, 2025 14:16
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline.


"""
Export an LLM with ExecuTorch. Currently follows the following steps:
1. Instantiate our custom PyTorch transformer definition from examples/llama/models/llama_transformer.py.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mention implementation details in the docblock.

If it's a public API, the docblock should contain description of the contract.

Copy link
Contributor Author

@jackzhxng jackzhxng Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will move this information to a README

@jackzhxng jackzhxng linked an issue Jun 18, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce export_llama to extension/llm as export_llm
4 participants