add typing to pybindings #120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48634638 |
|
This pull request was exported from Phabricator. Differential Revision: D48634638 |
JacobSzwejbka
force-pushed
the
export-D48634638
branch
from
afadcab to
baf14cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48634638 |
JacobSzwejbka
force-pushed
the
export-D48634638
branch
from
baf14cc to
9cc0e1e
Compare
Summary: Pull Request resolved: pytorch/executorch#120 .pyi file is needed for pyre to recognize the pybindings. Additionally you have to name the .pyi exactly the name of the pybinding lib which is problematic for us because we have 4 libs and 2 arent public. To make matters worse the types arg in the buck rule doesnt handle targets in the same manner as srcs. Put all this together and you get the weird genrule logic in the build files. A couple of pyre-ignores remain in the test due to the program/operator meta apis that arent in the .pyi because Im going to move them out of pybindings extension Reviewed By: cccclai Differential Revision: D48634638 fbshipit-source-id: 0cf8855d1e455f098b52ffb1f880a9264e35d151
|
This pull request was exported from Phabricator. Differential Revision: D48634638 |
JacobSzwejbka
force-pushed
the
export-D48634638
branch
from
9cc0e1e to
68c5ee3
Compare
|
This pull request has been merged in 3794945. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
.pyi file is needed for pyre to recognize the pybindings. Additionally you have to name the .pyi exactly the name of the pybinding lib which is problematic for us because we have 4 libs and 2 arent public. To make matters worse the types arg in the buck rule doesnt handle targets in the same manner as srcs. Put all this together and you get the weird genrule logic in the build files.
A couple of pyre-ignores remain in the test due to the program/operator meta apis that arent in the .pyi because Im going to move them out of pybindings extension
Differential Revision: D48634638