[MPS] Fix mps_executor_runner build when using cmake #1216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1216
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 8b79f3e with merge base cb2ff0f ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
DenisVieriu97
changed the title
DenisVieriu97
force-pushed
the
fix_bundled_program_mps_cmake
branch
from
1fda383 to
8b79f3e
Compare
shoumikhin
approved these changes
Nov 30, 2023
|
@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CMake is used to build the MPS runtime (mps_executor_runner). After the change from #1057, the bundled program schema is not generated automatically anymore part of
schema/CMakeLists.txt, but instead it's part ofsdk/CMakeLists.txt.This change adds the bundled_program schema generation for the
mps_executor_runnerback as the MPS runtime relies on the bundled program feature to check against the eager results.