refactor pybindings #126
Closed
refactor pybindings #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tensor conversions (#121) Summary: Pull Request resolved: pytorch/executorch#121 Keepalive was difficult to manage and Im not even sure how sound it was for things like strides and dim order. Now the run_method loop is a little grosser, but I think the intent is much clearer. We cast from python types to at types, and then possible have to do a hard conversion from at::tensor to ETensor which can be pretty gross since ETensor doesnt manage any memory. This highlights the need for like an ETensor wrapper that manages a bunch of state like sizes and TensorImpl Differential Revision: https://internalfb.com/D48618092 fbshipit-source-id: 1df77d197de435bc51d891af2b82e7156265a6b4
Differential Revision: https://internalfb.com/D48662995 fbshipit-source-id: 94ca60c074d41dff1fe9237a357bdf498a2e3b7e
Summary: Now that the codegen stuff is moved we can simplify a lot of the build system here. Also renamed module.cpp because its more then just the module api Differential Revision: D48667529 fbshipit-source-id: a9e1e766b22370675c99eaa95a2ab7740f968ea8
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48667529 |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
* macos12 full build (x86) * add support for setting precision via --dtype * setup default dtype as float32 * setup default dtype as float32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Now that the codegen stuff is moved we can simplify a lot of the build system here. Also renamed module.cpp because its more then just the module api
Differential Revision: D48667529