Fix XNNPACK Example for MV3 #147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D48667679 fbshipit-source-id: 961dda60a88209f85e95276ce26cbc6d8ccc3a4b
Differential Revision: D48667676 fbshipit-source-id: 9998b49f97971029545a4d3698de501e2edade56
Differential Revision: D48667680 fbshipit-source-id: 2b69e340dbadd1cd0215e4b128e3952c0fe94f45
Differential Revision: D48667678 fbshipit-source-id: 97e0dcfb04c3185fb3da3356e15ea1bb5ae9c041
Summary: xnnpack requires dequant nodes to be duplicated such that len(dq.users) == 1. We run this pass on our internal XNNPACK tests From Jerry: This will be a config that is used within the XNNPACKQuantizer. This will be added later, for the sake of enabling this in the example, we add the duplicatedequantnodepass to our edge compile config Additionally, graph_validation is failing for MV3, so we have to disable_validation for now. cccclai is looking into it Reviewed By: digantdesai Differential Revision: D48703639 fbshipit-source-id: 6bdca0480ea90782fc6a857095ec773d5ded1071
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48703639 |
|
This pull request has been merged in 9ede813. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
* tiktoken integration, part 1 * update tests * dtype tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
xnnpack requires dequant nodes to be duplicated such that len(dq.users) == 1. We run this pass on our internal XNNPACK tests
From Jerry: This will be a config that is used within the XNNPACKQuantizer. This will be added later, for the sake of enabling this in the example, we add the duplicatedequantnodepass to our edge compile config
Additionally, graph_validation is failing for MV3, so we have to disable_validation for now. cccclai is looking into it
Reviewed By: digantdesai
Differential Revision: D48703639