Skip to content

Constant segment runtime tests #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Jan 2, 2024

Summary:

  • load segment when constants are in segment
  • no segments when constants are in flatbuffer

Differential Revision: D52434413

Copy link

pytorch-bot bot commented Jan 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1505

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ea90b6d with merge base a81c2d4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52434413

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Jan 2, 2024
Summary:

- load segment when constants are in segment
- no segments when constants are in flatbuffer

Reviewed By: dbort

Differential Revision: D52434413
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52434413

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Jan 2, 2024
Summary:

- load segment when constants are in segment
- no segments when constants are in flatbuffer

Reviewed By: dbort

Differential Revision: D52434413
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52434413

Summary:

- load segment when constants are in segment
- no segments when constants are in flatbuffer

Reviewed By: dbort

Differential Revision: D52434413
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52434413

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52434413

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Jan 3, 2024
Summary:

- load segment when constants are in segment
- no segments when constants are in flatbuffer

Reviewed By: dbort

Differential Revision: D52434413
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 504366f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants