Skip to content

Check for missing arrays in Program #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Jan 3, 2024

Summary: Flatbuffer array fields can be missing, so we need to check for nullptr before calling size() on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423

Copy link

pytorch-bot bot commented Jan 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1519

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 188156d with merge base a81c2d4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52493423

dbort added a commit to dbort/executorch that referenced this pull request Jan 3, 2024
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
dbort added 2 commits January 2, 2024 16:57
Summary:

Don't fail fatally if the .pte file contains an unknown type enum value. Discovered by lionhead fuzzing.

Differential Revision: D52493415
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
dbort added a commit to dbort/executorch that referenced this pull request Jan 3, 2024
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
@dbort dbort force-pushed the export-D52493423 branch from eb40380 to 188156d Compare January 3, 2024 00:57
dbort added a commit to dbort/executorch that referenced this pull request Jan 3, 2024
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52493423

dbort added a commit to dbort/executorch that referenced this pull request Jan 3, 2024
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
dbort added a commit to dbort/executorch that referenced this pull request Jan 3, 2024
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
dbort added a commit to dbort/executorch that referenced this pull request Jan 3, 2024
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
dbort added a commit to dbort/executorch that referenced this pull request Jan 3, 2024
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
dbort added a commit to dbort/executorch that referenced this pull request Jan 3, 2024
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
dbort added a commit to dbort/executorch that referenced this pull request Jan 3, 2024
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
dbort added a commit to dbort/executorch that referenced this pull request Jan 3, 2024
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
dbort added a commit to dbort/executorch that referenced this pull request Jan 3, 2024
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
dbort added a commit to dbort/executorch that referenced this pull request Jan 3, 2024
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
dbort added a commit to dbort/executorch that referenced this pull request Jan 3, 2024
Summary:

Flatbuffer array fields can be missing, so we need to check for `nullptr` before calling `size()` on them. Discovered by lionhead fuzzing.

Differential Revision: D52493423
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d869385.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants