Improve verifier to not specialize on dialect. #1528
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1528
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 0706f47 with merge base 1993d92 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52499225 |
zhxchen17
force-pushed
the
export-D52499225
branch
from
25e95ba to
a5644f1
Compare
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Jan 3, 2024
Summary:
Currently we have a very ugly specialization on edge dialect in verifier like the following:
```
# TODO Remove this branch.
if ep.dialect == "EDGE": # !!! Don't change this allowlist. !!!
pass
else:
raise e
```
In this diff we do some additional work to make signature checking also work in exir. We decouple the transformation stack in torch export and exir so that different layers of the stack can evolve in their own fashion and the team can divide and conquer them seperately.
Differential Revision: D52499225
|
This pull request was exported from Phabricator. Differential Revision: D52499225 |
zhxchen17
force-pushed
the
export-D52499225
branch
from
a5644f1 to
ddb6a6a
Compare
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Jan 3, 2024
Summary: X-link: pytorch/pytorch#116705 Currently we have a very ugly specialization on edge dialect in verifier like the following: ``` # TODO Remove this branch. if ep.dialect == "EDGE": # !!! Don't change this allowlist. !!! pass else: raise e ``` In this diff we do some additional work to make signature checking also work in exir. We decouple the transformation stack in torch export and exir so that different layers of the stack can evolve in their own fashion and the team can divide and conquer them seperately. Reviewed By: angelayi Differential Revision: D52499225
|
This pull request was exported from Phabricator. Differential Revision: D52499225 |
zhxchen17
force-pushed
the
export-D52499225
branch
from
ddb6a6a to
37dbd4a
Compare
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Jan 3, 2024
Summary: X-link: pytorch/pytorch#116705 Currently we have a very ugly specialization on edge dialect in verifier like the following: ``` # TODO Remove this branch. if ep.dialect == "EDGE": # !!! Don't change this allowlist. !!! pass else: raise e ``` In this diff we do some additional work to make signature checking also work in exir. We decouple the transformation stack in torch export and exir so that different layers of the stack can evolve in their own fashion and the team can divide and conquer them seperately. Reviewed By: angelayi Differential Revision: D52499225
zhxchen17
added a commit
to zhxchen17/pytorch
that referenced
this pull request
Jan 3, 2024
Summary: X-link: pytorch/executorch#1528 Currently we have a very ugly specialization on edge dialect in verifier like the following: ``` # TODO Remove this branch. if ep.dialect == "EDGE": # !!! Don't change this allowlist. !!! pass else: raise e ``` In this diff we do some additional work to make signature checking also work in exir. We decouple the transformation stack in torch export and exir so that different layers of the stack can evolve in their own fashion and the team can divide and conquer them seperately. Test Plan: CI Reviewed By: angelayi Differential Revision: D52499225
|
This pull request was exported from Phabricator. Differential Revision: D52499225 |
zhxchen17
force-pushed
the
export-D52499225
branch
from
37dbd4a to
68328ea
Compare
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Jan 4, 2024
Summary: X-link: pytorch/pytorch#116705 Currently we have a very ugly specialization on edge dialect in verifier like the following: ``` # TODO Remove this branch. if ep.dialect == "EDGE": # !!! Don't change this allowlist. !!! pass else: raise e ``` In this diff we do some additional work to make signature checking also work in exir. We decouple the transformation stack in torch export and exir so that different layers of the stack can evolve in their own fashion and the team can divide and conquer them seperately. Reviewed By: angelayi Differential Revision: D52499225
|
This pull request was exported from Phabricator. Differential Revision: D52499225 |
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Jan 4, 2024
Summary: X-link: pytorch/pytorch#116705 Currently we have a very ugly specialization on edge dialect in verifier like the following: ``` # TODO Remove this branch. if ep.dialect == "EDGE": # !!! Don't change this allowlist. !!! pass else: raise e ``` In this diff we do some additional work to make signature checking also work in exir. We decouple the transformation stack in torch export and exir so that different layers of the stack can evolve in their own fashion and the team can divide and conquer them seperately. Reviewed By: angelayi Differential Revision: D52499225
zhxchen17
force-pushed
the
export-D52499225
branch
from
68328ea to
d273db8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52499225 |
Summary: X-link: pytorch/pytorch#116705 Currently we have a very ugly specialization on edge dialect in verifier like the following: ``` # TODO Remove this branch. if ep.dialect == "EDGE": # !!! Don't change this allowlist. !!! pass else: raise e ``` In this diff we do some additional work to make signature checking also work in exir. We decouple the transformation stack in torch export and exir so that different layers of the stack can evolve in their own fashion and the team can divide and conquer them seperately. Reviewed By: angelayi Differential Revision: D52499225
zhxchen17
added a commit
to zhxchen17/executorch-1
that referenced
this pull request
Jan 4, 2024
Summary: X-link: pytorch/pytorch#116705 Currently we have a very ugly specialization on edge dialect in verifier like the following: ``` # TODO Remove this branch. if ep.dialect == "EDGE": # !!! Don't change this allowlist. !!! pass else: raise e ``` In this diff we do some additional work to make signature checking also work in exir. We decouple the transformation stack in torch export and exir so that different layers of the stack can evolve in their own fashion and the team can divide and conquer them seperately. Reviewed By: angelayi Differential Revision: D52499225
zhxchen17
force-pushed
the
export-D52499225
branch
from
d273db8 to
6283cc0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52499225 |
zhxchen17
force-pushed
the
export-D52499225
branch
from
6283cc0 to
0706f47
Compare
zhxchen17
added a commit
to zhxchen17/pytorch
that referenced
this pull request
Jan 4, 2024
Summary: X-link: pytorch/executorch#1528 Currently we have a very ugly specialization on edge dialect in verifier like the following: ``` # TODO Remove this branch. if ep.dialect == "EDGE": # !!! Don't change this allowlist. !!! pass else: raise e ``` In this diff we do some additional work to make signature checking also work in exir. We decouple the transformation stack in torch export and exir so that different layers of the stack can evolve in their own fashion and the team can divide and conquer them seperately. Test Plan: CI Reviewed By: angelayi Differential Revision: D52499225
|
This pull request was exported from Phabricator. Differential Revision: D52499225 |
|
This pull request has been merged in f37bb47. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently we have a very ugly specialization on edge dialect in verifier like the following:
In this diff we do some additional work to make signature checking also work in exir. We decouple the transformation stack in torch export and exir so that different layers of the stack can evolve in their own fashion and the team can divide and conquer them seperately.
Differential Revision: D52499225