Fix some printf warnings in executor_runner.cpp #1529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1529
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 50bc720 with merge base f37bb47 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52528480 |
dbort
force-pushed
the
export-D52528480
branch
from
dd156fa to
7670f40
Compare
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Jan 4, 2024
Summary: Some compilers don't like passing enums as printf arguments without casting them first. Differential Revision: D52528480
Summary: Ensure that the `args` arrays of `KernelCall` and `DelegateCall` instruction entries are present before using them. Reviewed By: larryliu0820 Differential Revision: D52451746
Summary: Don't use the backend ID field unless it's present. Reviewed By: lucylq Differential Revision: D52451737
…torch#1507) Summary: Some MethodMeta methods don't return Error, assuming that the underlying data is valid. Ensure that the underlying ExecutionPlan is valid for those fields before returning a MethodMeta. For fields whose accessors do return Error or Result, we can check them at the time they're called and return non-fatally then. Reviewed By: lucylq Differential Revision: D52451736
Summary: I forgot to remove this from D52451739. Differential Revision: D52528209
Summary: Some compilers don't like passing enums as printf arguments without casting them first. Differential Revision: D52528480
|
This pull request was exported from Phabricator. Differential Revision: D52528480 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Jan 4, 2024
Summary: Some compilers don't like passing enums as printf arguments without casting them first. Differential Revision: D52528480
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Jan 4, 2024
Summary: Some compilers don't like passing enums as printf arguments without casting them first. Differential Revision: D52528480
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Jan 4, 2024
Summary: Some compilers don't like passing enums as printf arguments without casting them first. Differential Revision: D52528480
dbort
force-pushed
the
export-D52528480
branch
from
7670f40 to
50bc720
Compare
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Jan 4, 2024
Summary: Some compilers don't like passing enums as printf arguments without casting them first. Differential Revision: D52528480
|
This pull request was exported from Phabricator. Differential Revision: D52528480 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Jan 4, 2024
Summary: Some compilers don't like passing enums as printf arguments without casting them first. Differential Revision: D52528480
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Jan 4, 2024
Summary: Some compilers don't like passing enums as printf arguments without casting them first. Reviewed By: larryliu0820 Differential Revision: D52528480
|
This pull request has been merged in e089910. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Some compilers don't like passing enums as printf arguments without casting them first.
Differential Revision: D52528480