Add support for outputting constants #1774
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1774
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ec93a10 with merge base 5d0a7a0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53256808 |
tarun292
added a commit
that referenced
this pull request
Feb 2, 2024
Summary: For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these. Differential Revision: D53256808
tarun292
force-pushed
the
export-D53256808
branch
from
be96db0 to
b9b341d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53256808 |
tarun292
added a commit
that referenced
this pull request
Feb 2, 2024
Summary: For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these. Differential Revision: D53256808
tarun292
force-pushed
the
export-D53256808
branch
from
b9b341d to
e34e857
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53256808 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
Summary: For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these. Differential Revision: D53256808
facebook-github-bot
force-pushed
the
export-D53256808
branch
from
e34e857 to
aa55556
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53256808 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
Summary: For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these. Differential Revision: D53256808
tarun292
added a commit
that referenced
this pull request
Feb 2, 2024
Summary: For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these. Differential Revision: D53256808
tarun292
force-pushed
the
export-D53256808
branch
from
aa55556 to
ca536da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53256808 |
tarun292
added a commit
that referenced
this pull request
Feb 15, 2024
Summary: For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these. Reviewed By: angelayi Differential Revision: D53256808
tarun292
added a commit
that referenced
this pull request
Feb 15, 2024
Summary: For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these. Reviewed By: angelayi Differential Revision: D53256808
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
Summary: For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these. Reviewed By: angelayi Differential Revision: D53256808
facebook-github-bot
force-pushed
the
export-D53256808
branch
from
ca536da to
5358f7f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53256808 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
Summary: For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these. Reviewed By: angelayi Differential Revision: D53256808
tarun292
added a commit
that referenced
this pull request
Feb 15, 2024
Summary: For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these. Reviewed By: angelayi Differential Revision: D53256808
tarun292
force-pushed
the
export-D53256808
branch
from
5358f7f to
153c339
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53256808 |
tarun292
added a commit
that referenced
this pull request
Feb 15, 2024
Summary: For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these. Reviewed By: angelayi Differential Revision: D53256808
tarun292
force-pushed
the
export-D53256808
branch
from
153c339 to
256ce2f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53256808 |
Summary: For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these. Reviewed By: angelayi Differential Revision: D53256808
tarun292
force-pushed
the
export-D53256808
branch
from
256ce2f to
ec93a10
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53256808 |
|
This pull request has been merged in 5d7edcb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these.
Differential Revision: D53256808