Add seq_len to llama runner for early stopping #2051
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2051
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 65449cc with merge base ca6995b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53873431 |
vmpuri
pushed a commit
to vmpuri/executorch-1
that referenced
this pull request
Feb 23, 2024
Summary: By default, the llama runner will continue generating until max_seq_len. This is a property embedded in the model metadata. We want a way to limit the number of tokens generated. Reviewed By: larryliu0820 Differential Revision: D53873431
vmpuri
force-pushed
the
export-D53873431
branch
from
91f989b to
9328aa8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53873431 |
vmpuri
pushed a commit
to vmpuri/executorch-1
that referenced
this pull request
Feb 23, 2024
Summary: By default, the llama runner will continue generating until max_seq_len. This is a property embedded in the model metadata. We want a way to limit the number of tokens generated. Reviewed By: larryliu0820 Differential Revision: D53873431
vmpuri
force-pushed
the
export-D53873431
branch
from
9328aa8 to
d8dd4f2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53873431 |
vmpuri
pushed a commit
to vmpuri/executorch-1
that referenced
this pull request
Feb 23, 2024
Summary: By default, the llama runner will continue generating until max_seq_len. This is a property embedded in the model metadata. We want a way to limit the number of tokens generated. Reviewed By: larryliu0820 Differential Revision: D53873431
vmpuri
force-pushed
the
export-D53873431
branch
from
d8dd4f2 to
832a475
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53873431 |
vmpuri
pushed a commit
to vmpuri/executorch-1
that referenced
this pull request
Feb 23, 2024
Summary: By default, the llama runner will continue generating until max_seq_len. This is a property embedded in the model metadata. We want a way to limit the number of tokens generated. Reviewed By: larryliu0820 Differential Revision: D53873431
vmpuri
force-pushed
the
export-D53873431
branch
from
832a475 to
b252899
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53873431 |
vmpuri
pushed a commit
to vmpuri/executorch-1
that referenced
this pull request
Feb 23, 2024
Summary: By default, the llama runner will continue generating until max_seq_len. This is a property embedded in the model metadata. We want a way to limit the number of tokens generated. Reviewed By: larryliu0820 Differential Revision: D53873431
vmpuri
force-pushed
the
export-D53873431
branch
from
b252899 to
8117db4
Compare
vmpuri
pushed a commit
to vmpuri/executorch-1
that referenced
this pull request
Feb 23, 2024
Summary: By default, the llama runner will continue generating until max_seq_len. This is a property embedded in the model metadata. We want a way to limit the number of tokens generated. Reviewed By: larryliu0820 Differential Revision: D53873431
vmpuri
force-pushed
the
export-D53873431
branch
from
8117db4 to
4cb804f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53873431 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D53873431 |
Jack-Khuu
approved these changes
Feb 23, 2024
Summary: By default, the llama runner will continue generating until max_seq_len. This is a property embedded in the model metadata. We want a way to limit the number of tokens generated. Reviewed By: Jack-Khuu, larryliu0820 Differential Revision: D53873431
vmpuri
force-pushed
the
export-D53873431
branch
from
4cb804f to
65449cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53873431 |
|
This pull request has been merged in 33ba563. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: By default, the llama runner will continue generating until max_seq_len. This is a property embedded in the model metadata. We want a way to limit the number of tokens generated.
Reviewed By: larryliu0820
Differential Revision: D53873431