Fix of the test-arm-backend-delegation flow #2143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Elliott <[email protected]>
…d-delegation and test-arm-reference-delegation to use the per-test setup.sh artefacts. Signed-off-by: Rob Elliott <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2143
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 30aa02d with merge base f327e53 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
robell
added
the
partner: arm
|
hi @larryliu0820 - I don't think these llama job failures are due to my changes - more likely from the llama test enabling in #2092 ? edit: I've now merged changes from main so this hopefully reintroduces the new script options for those tests to pass. |
Signed-off-by: Rob Elliott <[email protected]>
Signed-off-by: Rob Elliott <[email protected]>
Signed-off-by: Rob Elliott <[email protected]>
mergennachin
approved these changes
Feb 28, 2024
|
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mergennachin merged this pull request in 843db93. |
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few oddities in the test setup, hopefully this fixes #2011 and fixes #1947.
Probably fixes #1750 as well.
The change is to use a per-test-run build of the setup.sh / SDK components rather than one in /opt/arm-sdk - the setup.sh inlcudes a pip install of a vela executable into the venv path which was not correctly carried through into the test run.
Once this works we can remove the Docker stage which is running setup.sh