Skip to content

Update XNNPACK revision to fcbf55a #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GregoryComer
Copy link
Member

Update the revision of the XNNPACK library dependency to fcbf55a. Note that this is part of a synchronized update of XNNPACK for ExecuTorch, PyTorch, and Meta internal.

Copy link

pytorch-bot bot commented Mar 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2223

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ec0ca4e with merge base 8299fe3 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2024
@GregoryComer GregoryComer force-pushed the features/xnnpack-update branch 6 times, most recently from e4409cb to a0939dd Compare March 4, 2024 07:27
@GregoryComer GregoryComer force-pushed the features/xnnpack-update branch from a0939dd to ec0ca4e Compare March 4, 2024 09:24
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@GregoryComer GregoryComer marked this pull request as ready for review March 4, 2024 19:32
Copy link
Contributor

@mcr229 mcr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

mcr229 pushed a commit to mcr229/executorch that referenced this pull request Mar 4, 2024
Summary:
Update the revision of the XNNPACK library dependency to fcbf55a. Note that this is part of a synchronized update of XNNPACK for ExecuTorch, PyTorch, and Meta internal.

Pull Request resolved: pytorch#2223

Differential Revision: D54499911

Pulled By: GregoryComer
mcr229 pushed a commit to mcr229/executorch that referenced this pull request Mar 4, 2024
Summary:
Update the revision of the XNNPACK library dependency to fcbf55a. Note that this is part of a synchronized update of XNNPACK for ExecuTorch, PyTorch, and Meta internal.

Pull Request resolved: pytorch#2223

Differential Revision: D54499911

Pulled By: GregoryComer
mcr229 pushed a commit to mcr229/executorch that referenced this pull request Mar 6, 2024
Summary:
Update the revision of the XNNPACK library dependency to fcbf55a. Note that this is part of a synchronized update of XNNPACK for ExecuTorch, PyTorch, and Meta internal.

Pull Request resolved: pytorch#2223

Differential Revision: D54499911

Pulled By: GregoryComer
@facebook-github-bot
Copy link
Contributor

@GregoryComer merged this pull request in c7fb967.

facebook-github-bot pushed a commit that referenced this pull request Mar 8, 2024
Summary:
During the XNNPACK update (#2223), wrappers were mistakenly not added due to internal diff and OSS PR being out of sync. This PR restores the wrappers to fix the OSS build.

bypass-github-export-checks
bypass-github-executorch-ci-checks

Pull Request resolved: #2313

Test Plan:
OSS CI comes back clean for the build
OSS CMake build succeeds
OSS Buck build of xnnpack backend succeeds

Reviewed By: mcr229

Differential Revision: D54665437

Pulled By: GregoryComer

fbshipit-source-id: 6385be1281b61c1e9de86742ac64f2079818dbb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants