Skip to content

Add cord data structure #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Mar 6, 2024

Summary:
Introduce cord data structure to store bytes/bytearrays during serialization.

This allows us to manipulate bytes/bytearrays without copying data.

Reviewed By: dbort

Differential Revision: D54514244

Copy link

pytorch-bot bot commented Mar 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2273

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 24dd792 with merge base c0167c5 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Mar 6, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54514244

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 6, 2024
Summary:

Introduce cord data structure to store bytes/bytearrays during serialization.

This allows us to manipulate bytes/bytearrays without copying data.

Reviewed By: dbort

Differential Revision: D54514244
@lucylq lucylq force-pushed the export-D54514244 branch from de524df to 4583941 Compare March 6, 2024 02:37
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54514244

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 6, 2024
Summary:

Introduce cord data structure to store bytes/bytearrays during serialization.

This allows us to manipulate bytes/bytearrays without copying data.

Reviewed By: dbort

Differential Revision: D54514244
@lucylq lucylq force-pushed the export-D54514244 branch from 4583941 to f1467b0 Compare March 6, 2024 17:57
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54514244

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 6, 2024
Summary:

Introduce cord data structure to store bytes/bytearrays during serialization.

This allows us to manipulate bytes/bytearrays without copying data.

Reviewed By: dbort

Differential Revision: D54514244
@lucylq lucylq force-pushed the export-D54514244 branch from f1467b0 to 1b7862c Compare March 6, 2024 17:57
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54514244

@lucylq lucylq force-pushed the export-D54514244 branch from 1b7862c to ac1ac95 Compare March 6, 2024 19:01
lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 6, 2024
Summary:

Introduce cord data structure to store bytes/bytearrays during serialization.

This allows us to manipulate bytes/bytearrays without copying data.

Reviewed By: dbort

Differential Revision: D54514244
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54514244

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 6, 2024
Summary:

Introduce cord data structure to store bytes/bytearrays during serialization.

This allows us to manipulate bytes/bytearrays without copying data.

Reviewed By: dbort

Differential Revision: D54514244
@lucylq lucylq force-pushed the export-D54514244 branch from ac1ac95 to 71a6a9e Compare March 6, 2024 19:01
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54514244

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 6, 2024
Summary:

Introduce cord data structure to store bytes/bytearrays during serialization.

This allows us to manipulate bytes/bytearrays without copying data.

Reviewed By: dbort

Differential Revision: D54514244
@lucylq lucylq force-pushed the export-D54514244 branch from 71a6a9e to a421c05 Compare March 6, 2024 19:29
Summary:

Introduce cord data structure to store bytes/bytearrays during serialization.

This allows us to manipulate bytes/bytearrays without copying data.

Reviewed By: dbort

Differential Revision: D54514244
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54514244

@lucylq lucylq force-pushed the export-D54514244 branch from a421c05 to 24dd792 Compare March 6, 2024 19:29
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54514244

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0570294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants