Serialize union fields with single entry dict. #2279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2279
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit be1dc50 with merge base 3b0dd33 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54600943 |
Summary:
remove "$type" and "$value" fields, instead only serialize as {type: value} for union fields directly.
bypass-github-export-checks
Differential Revision: D54600943
zhxchen17
added a commit
to zhxchen17/pytorch
that referenced
this pull request
Mar 6, 2024
Summary: X-link: pytorch/executorch#2279 remove "$type" and "$value" fields, instead only serialize as {type: value} for union fields directly. bypass-github-export-checks Test Plan: CI Differential Revision: D54600943
zhxchen17
force-pushed
the
export-D54600943
branch
from
8b40aa2 to
be1dc50
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54600943 |
tugsbayasgalan
approved these changes
Mar 7, 2024
|
This pull request has been merged in 6be02ce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/pytorch#121263
remove "$type" and "$value" fields, instead only serialize as {type: value} for union fields directly.
bypass-github-export-checks
Differential Revision: D54600943