Add fuse_dq_q_pass in exir/passes and also add it to HTP backend #2295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2295
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 1a5f23d with merge base 091e524 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54543323 |
tarun292
added a commit
that referenced
this pull request
Mar 7, 2024
Summary: There are passes such as these https://fburl.com/code/vs6n4vcv that remove noops from the graph. The problem is that after this pass runs it still leaves in the dq->q nodes in the graph which then potentially get delegated to the backend causing perf regressions. This pass will remove the dq->q ops if their qparams are of the same value. If not it won't touch them. Differential Revision: D54543323
tarun292
force-pushed
the
export-D54543323
branch
from
6a93f2d to
f004294
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54543323 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D54543323 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
Summary: There are passes such as these https://fburl.com/code/vs6n4vcv that remove noops from the graph. The problem is that after this pass runs it still leaves in the dq->q nodes in the graph which then potentially get delegated to the backend causing perf regressions. This pass will remove the dq->q ops if their qparams are of the same value. If not it won't touch them. Differential Revision: D54543323
facebook-github-bot
force-pushed
the
export-D54543323
branch
from
f004294 to
e860f35
Compare
tarun292
force-pushed
the
export-D54543323
branch
from
e860f35 to
68d29f7
Compare
tarun292
added a commit
that referenced
this pull request
Mar 13, 2024
Summary: There are passes such as these https://fburl.com/code/vs6n4vcv that remove noops from the graph. The problem is that after this pass runs it still leaves in the dq->q nodes in the graph which then potentially get delegated to the backend causing perf regressions. This pass will remove the dq->q ops if their qparams are of the same value. If not it won't touch them. Differential Revision: D54543323
|
This pull request was exported from Phabricator. Differential Revision: D54543323 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D54543323 |
tarun292
added a commit
that referenced
this pull request
Mar 18, 2024
Summary: There are passes such as these https://fburl.com/code/vs6n4vcv that remove noops from the graph. The problem is that after this pass runs it still leaves in the dq->q nodes in the graph which then potentially get delegated to the backend causing perf regressions. This pass will remove the dq->q ops if their qparams are of the same value. If not it won't touch them. Reviewed By: kimishpatel Differential Revision: D54543323
tarun292
force-pushed
the
export-D54543323
branch
from
ec18ba3 to
7f74c06
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54543323 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
Summary: There are passes such as these https://fburl.com/code/vs6n4vcv that remove noops from the graph. The problem is that after this pass runs it still leaves in the dq->q nodes in the graph which then potentially get delegated to the backend causing perf regressions. This pass will remove the dq->q ops if their qparams are of the same value. If not it won't touch them. Reviewed By: kimishpatel Differential Revision: D54543323
facebook-github-bot
force-pushed
the
export-D54543323
branch
from
68d29f7 to
ec18ba3
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
Summary: There are passes such as these https://fburl.com/code/vs6n4vcv that remove noops from the graph. The problem is that after this pass runs it still leaves in the dq->q nodes in the graph which then potentially get delegated to the backend causing perf regressions. This pass will remove the dq->q ops if their qparams are of the same value. If not it won't touch them. Reviewed By: kimishpatel Differential Revision: D54543323
facebook-github-bot
force-pushed
the
export-D54543323
branch
from
7f74c06 to
1e12ffa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54543323 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D54543323 |
tarun292
added a commit
that referenced
this pull request
Mar 29, 2024
Summary: Pull Request resolved: #2295 There are passes such as these https://fburl.com/code/vs6n4vcv that remove noops from the graph. The problem is that after this pass runs it still leaves in the dq->q nodes in the graph which then potentially get delegated to the backend causing perf regressions. This pass will remove the dq->q ops if their qparams are of the same value. If not it won't touch them. Reviewed By: kimishpatel Differential Revision: D54543323
tarun292
force-pushed
the
export-D54543323
branch
from
1e12ffa to
ba03b6b
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 1, 2024
Summary: There are passes such as these https://fburl.com/code/vs6n4vcv that remove noops from the graph. The problem is that after this pass runs it still leaves in the dq->q nodes in the graph which then potentially get delegated to the backend causing perf regressions. This pass will remove the dq->q ops if their qparams are of the same value. If not it won't touch them. Reviewed By: kimishpatel Differential Revision: D54543323
facebook-github-bot
force-pushed
the
export-D54543323
branch
from
ba03b6b to
daafbc7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54543323 |
tarun292
added a commit
that referenced
this pull request
Apr 1, 2024
Summary: There are passes such as these https://fburl.com/code/vs6n4vcv that remove noops from the graph. The problem is that after this pass runs it still leaves in the dq->q nodes in the graph which then potentially get delegated to the backend causing perf regressions. This pass will remove the dq->q ops if their qparams are of the same value. If not it won't touch them. Reviewed By: kimishpatel Differential Revision: D54543323
tarun292
force-pushed
the
export-D54543323
branch
from
daafbc7 to
fda6d5e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54543323 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 1, 2024
Summary: There are passes such as these https://fburl.com/code/vs6n4vcv that remove noops from the graph. The problem is that after this pass runs it still leaves in the dq->q nodes in the graph which then potentially get delegated to the backend causing perf regressions. This pass will remove the dq->q ops if their qparams are of the same value. If not it won't touch them. Reviewed By: kimishpatel Differential Revision: D54543323
facebook-github-bot
force-pushed
the
export-D54543323
branch
from
fda6d5e to
10e03b1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54543323 |
Summary: There are passes such as these https://fburl.com/code/vs6n4vcv that remove noops from the graph. The problem is that after this pass runs it still leaves in the dq->q nodes in the graph which then potentially get delegated to the backend causing perf regressions. This pass will remove the dq->q ops if their qparams are of the same value. If not it won't touch them. Reviewed By: kimishpatel Differential Revision: D54543323
|
This pull request was exported from Phabricator. Differential Revision: D54543323 |
tarun292
force-pushed
the
export-D54543323
branch
from
10e03b1 to
1a5f23d
Compare
|
This pull request has been merged in 24477df. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There are passes such as these https://fburl.com/code/vs6n4vcv that remove noops from the graph. The problem is that after this pass runs it still leaves in the dq->q nodes in the graph which then potentially get delegated to the backend causing perf regressions.
This pass will remove the dq->q ops if their qparams are of the same value. If not it won't touch them.
Differential Revision: D54543323