remove exir.capture from model inventory #2302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2302
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 1707a8a with merge base a6e45f4 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54562526 |
JacobSzwejbka
force-pushed
the
export-D54562526
branch
from
8bb172d to
71b60a3
Compare
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 7, 2024
Summary: capture is deprecated we should be using export. Also deleted some tests that werent maintained and werent passing due to several reasons. Since this lib is basically on life support and we have coverage elsewhere I didnt want to spend a ton of time debugging. Reviewed By: Jack-Khuu, angelayi Differential Revision: D54562526
|
This pull request was exported from Phabricator. Differential Revision: D54562526 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 7, 2024
Summary: capture is deprecated we should be using export. Also deleted some tests that werent maintained and werent passing due to several reasons. Since this lib is basically on life support and we have coverage elsewhere I didnt want to spend a ton of time debugging. Reviewed By: Jack-Khuu, angelayi Differential Revision: D54562526
JacobSzwejbka
force-pushed
the
export-D54562526
branch
from
71b60a3 to
c67d9cb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54562526 |
JacobSzwejbka
force-pushed
the
export-D54562526
branch
from
c67d9cb to
53dc257
Compare
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 8, 2024
Summary: capture is deprecated we should be using export. Also deleted some tests that werent maintained and werent passing due to several reasons. Since this lib is basically on life support and we have coverage elsewhere I didnt want to spend a ton of time debugging. Reviewed By: Jack-Khuu, angelayi Differential Revision: D54562526
|
This pull request was exported from Phabricator. Differential Revision: D54562526 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 8, 2024
Summary: capture is deprecated we should be using export. Also deleted some tests that werent maintained and werent passing due to several reasons. Since this lib is basically on life support and we have coverage elsewhere I didnt want to spend a ton of time debugging. Reviewed By: Jack-Khuu, angelayi Differential Revision: D54562526
JacobSzwejbka
force-pushed
the
export-D54562526
branch
from
53dc257 to
b72ce60
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54562526 |
angelayi
approved these changes
Mar 8, 2024
JacobSzwejbka
force-pushed
the
export-D54562526
branch
from
b72ce60 to
9aea3ce
Compare
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 11, 2024
Summary: capture is deprecated we should be using export. Also deleted some tests that werent maintained and werent passing due to several reasons. Since this lib is basically on life support and we have coverage elsewhere I didnt want to spend a ton of time debugging. Reviewed By: Jack-Khuu, angelayi Differential Revision: D54562526
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 11, 2024
Summary: capture is deprecated we should be using export. Also deleted some tests that werent maintained and werent passing due to several reasons. Since this lib is basically on life support and we have coverage elsewhere I didnt want to spend a ton of time debugging. bypass-github-pytorch-ci-checks external ci is all broken this morning Reviewed By: Jack-Khuu, angelayi Differential Revision: D54562526
JacobSzwejbka
force-pushed
the
export-D54562526
branch
from
9aea3ce to
ae5a334
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54562526 |
Summary: capture is deprecated we should be using export. Also deleted some tests that werent maintained and werent passing due to several reasons. Since this lib is basically on life support and we have coverage elsewhere I didnt want to spend a ton of time debugging. external ci is all broken this morning bypass-github-pytorch-ci-checks Reviewed By: Jack-Khuu, angelayi Differential Revision: D54562526
JacobSzwejbka
force-pushed
the
export-D54562526
branch
from
ae5a334 to
1707a8a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54562526 |
|
This pull request has been merged in 4ef264e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: capture is deprecated we should be using export. Also deleted some tests that werent maintained and werent passing due to several reasons. Since this lib is basically on life support and we have coverage elsewhere I didnt want to spend a ton of time debugging.
Reviewed By: Jack-Khuu, angelayi
Differential Revision: D54562526