Skip to content

et_log #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

et_log #2303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions runtime/platform/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@ def _select_pal(dict_):
fail("Missing key for executorch.pal_default value '{}' in dict '{}'".format(pal_default, dict_))
return dict_[pal_default]

def logging_enabled():
return native.read_config("executorch", "enable_et_log", "true") == "true"

def get_logging_flags():
if logging_enabled():
# On by default.
return []
else:
return ["-DET_LOG_ENABLED=0"]

def profiling_enabled():
return native.read_config("executorch", "prof_enabled", "false") == "true"

Expand Down Expand Up @@ -57,9 +67,6 @@ def define_common_targets():
force_static = True,
)

# Enable or disable ET_LOGs
enable_et_log = native.read_config("executorch", "enable_et_log", None)

# Interfaces for executorch users
runtime.cxx_library(
name = "platform",
Expand All @@ -77,7 +84,7 @@ def define_common_targets():
"profiler.cpp",
"runtime.cpp",
],
exported_preprocessor_flags = get_profiling_flags() + (["-DET_LOG_ENABLED=0"] if enable_et_log else []),
exported_preprocessor_flags = get_profiling_flags() + get_logging_flags(),
exported_deps = [
"//executorch/runtime/platform:pal_interface",
":compiler",
Expand Down