Integrate sdk #2314
Integrate sdk #2314
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2314
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5ed3e73 with merge base 71ea7cb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
cymbalrush
force-pushed
the
coreml_sdk_integration
branch
3 times, most recently
from
6cbb79f to
8baea7f
Compare
|
@tarun292 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cymbalrush
force-pushed
the
coreml_sdk_integration
branch
from
8baea7f to
ff96112
Compare
|
@tarun292 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@shoumikhin @tarun292 seeing an internal build failure. I am guessing we have to update the internal buck file that builds the CoreML delegate. Some new files are added to the project that are included in the cmake file but are probably missing from the internal buck? |
cymbalrush
force-pushed
the
coreml_sdk_integration
branch
from
ff96112 to
5ed3e73
Compare
|
@tarun292 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@shoumikhin merged this pull request in ae84721. |
The PR adds support for logging profiling information and intermediate outputs. The required files are only included if CoreML delegate is built with
EXECUTORCH_BUILD_SDKoption.ETCoreMLModelProfileradds profiling support, it uses theMLComputePlanAPI that's currently in beta but unlikely to change. The caveat is that it only works for macOS >= 14.4, iOS >= 17.4.ETCoreMLModelDebuggeradds support for getting intermediate tensors. The model spec is updated to include additional intermediate outputs, compiled, and then executed. It has a dependency onprotobufas it modifies the specification of the model. The logging part doesn't work yet, it would require ExecuTorch API (log_tensor_delegate).coremltools.coremltoolswill add ajsonfile tomlpackagethat would contain the operation path to debug handle mapping.