[CoreML Backend] Optimize memory when exporting. #2341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2341
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit c418ec4 with merge base 2458717 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
cymbalrush
force-pushed
the
coreml_export_optimize_memory
branch
from
3f0fbff to
8a224c6
Compare
cymbalrush
force-pushed
the
coreml_export_optimize_memory
branch
from
8a224c6 to
f010dc6
Compare
cymbalrush
force-pushed
the
coreml_export_optimize_memory
branch
from
f010dc6 to
9acd21e
Compare
cymbalrush
changed the title
shoumikhin
approved these changes
Mar 17, 2024
|
@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cymbalrush
force-pushed
the
coreml_export_optimize_memory
branch
2 times, most recently
from
9566034 to
4d6922f
Compare
|
@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cymbalrush
force-pushed
the
coreml_export_optimize_memory
branch
from
4d6922f to
c418ec4
Compare
|
@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@shoumikhin merged this pull request in b3456eb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreML delegate when converting the
mlpackageto an in-memory representation reads the directory contents in themlpackagedirectory and writes it to a memory buffer this is expensive and the copying is not required.The change in the PR addresses by memory mapping the file contents to fixed addresses in the allocated memory, no memory is dirtied and the OS will bring the pages only when the bytes are read.