[Executorch][llama] Set # of threads to use performant cores #2352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using all cores, slower ones are dragging the performance down by blocking large cores. Perhaps when we have uarch specific implementation, we may not need this, but this tool is useful in general until we have better API Differential Revision: [D54766071](https://our.internmc.facebook.com/intern/diff/D54766071/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2352
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 08ad650 with merge base e98a7e0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54766071 |
When using all cores, slower ones are dragging the performance down by blocking large cores. Perhaps when we have uarch specific implementation, we may not need this, but this tool is useful in general until we have better API Differential Revision: [D54766071](https://our.internmc.facebook.com/intern/diff/D54766071/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D54766071 |
When using all cores, slower ones are dragging the performance down by blocking large cores. Perhaps when we have uarch specific implementation, we may not need this, but this tool is useful in general until we have better API Differential Revision: [D54766071](https://our.internmc.facebook.com/intern/diff/D54766071/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D54766071 |
kirklandsign
approved these changes
Mar 13, 2024
When using all cores, slower ones are dragging the performance down by blocking large cores. Perhaps when we have uarch specific implementation, we may not need this, but this tool is useful in general until we have better API Differential Revision: [D54766071](https://our.internmc.facebook.com/intern/diff/D54766071/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D54766071 |
When using all cores, slower ones are dragging the performance down by blocking large cores. Perhaps when we have uarch specific implementation, we may not need this, but this tool is useful in general until we have better API Differential Revision: [D54766071](https://our.internmc.facebook.com/intern/diff/D54766071/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D54766071 |
When using all cores, slower ones are dragging the performance down by blocking large cores. Perhaps when we have uarch specific implementation, we may not need this, but this tool is useful in general until we have better API Differential Revision: [D54766071](https://our.internmc.facebook.com/intern/diff/D54766071/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D54766071 |
When using all cores, slower ones are dragging the performance down by blocking large cores. Perhaps when we have uarch specific implementation, we may not need this, but this tool is useful in general until we have better API Differential Revision: [D54766071](https://our.internmc.facebook.com/intern/diff/D54766071/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D54766071 |
When using all cores, slower ones are dragging the performance down by blocking large cores. Perhaps when we have uarch specific implementation, we may not need this, but this tool is useful in general until we have better API Differential Revision: [D54766071](https://our.internmc.facebook.com/intern/diff/D54766071/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D54766071 |
When using all cores, slower ones are dragging the performance down by blocking large cores. Perhaps when we have uarch specific implementation, we may not need this, but this tool is useful in general until we have better API Differential Revision: [D54766071](https://our.internmc.facebook.com/intern/diff/D54766071/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D54766071 |
kimishpatel
added a commit
that referenced
this pull request
Mar 15, 2024
Pull Request resolved: #2352 When using all cores, slower ones are dragging the performance down by blocking large cores. Perhaps when we have uarch specific implementation, we may not need this, but this tool is useful in general until we have better API //unrelated failures @github-bypass-export-checks ghstack-source-id: 218830345 @exported-using-ghexport Differential Revision: [D54766071](https://our.internmc.facebook.com/intern/diff/D54766071/)
When using all cores, slower ones are dragging the performance down by blocking large cores. Perhaps when we have uarch specific implementation, we may not need this, but this tool is useful in general until we have better API Differential Revision: [D54766071](https://our.internmc.facebook.com/intern/diff/D54766071/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D54766071 |
|
This pull request has been merged in 391c498. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#2352 When using all cores, slower ones are dragging the performance down by blocking large cores. Perhaps when we have uarch specific implementation, we may not need this, but this tool is useful in general until we have better API //unrelated failures @github-bypass-export-checks ghstack-source-id: 218918368 @exported-using-ghexport Differential Revision: [D54766071](https://our.internmc.facebook.com/intern/diff/D54766071/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
When using all cores, slower ones are dragging the performance down by blocking
large cores. Perhaps when we have uarch specific implementation, we may not
need this, but this tool is useful in general until we have better API
Differential Revision: D54766071