Add config option for log level #2391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2391
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1708ac7 with merge base 4670211 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54800053 |
Summary: Add a buck config option to set the ExecuTorch log level. Used as follows: `buck2 run ... -c executorch.log_level=[level]` Where [level] is one of Debug, Info, Error, or Fatal (case-in-sensitive). Log methods are refactored into a separate bazel file to facilitate re-use. I need to override the XNNPACK log level when ET log level is set to Debug, and I don't want to duplicate the log level parsing logic. Differential Revision: D54800053
|
This pull request was exported from Phabricator. Differential Revision: D54800053 |
GregoryComer
force-pushed
the
export-D54800053
branch
from
131ce05 to
1708ac7
Compare
|
This pull request has been merged in 624ce59. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a buck config option to set the ExecuTorch log level. Used as follows:
buck2 run ... -c executorch.log_level=[level]Where [level] is one of Debug, Info, Error, or Fatal (case-in-sensitive).
Log methods are refactored into a separate bazel file to facilitate re-use. I need to override the XNNPACK log level when ET log level is set to Debug, and I don't want to duplicate the log level parsing logic.
Differential Revision: D54800053