Access last element of vector for current input details #2393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2393
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ca02bb6 with merge base 498141d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54836802 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
Summary: In pybindings when iterating on the inputs, preparing them for execution we were using the index `i` to access sizes, dim_order, strides etc. of the current tensor being iterated on. This worked previously because all our inputs were all always tensors. In the seamless model we ran into a case where the inputs are a mixed tuple of tensors and constants (int's). In this case index `i` is not accurate anymore when accessing `input_tensors` to get the current tensor being operated on because we haven't pushed `i` number of tensors into the `input_tensors` vector as some of the inputs till now were non-tensors. Differential Revision: D54836802
facebook-github-bot
force-pushed
the
export-D54836802
branch
from
06a7ad4 to
ce9f8ce
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54836802 |
Summary: In pybindings when iterating on the inputs, preparing them for execution we were using the index `i` to access sizes, dim_order, strides etc. of the current tensor being iterated on. This worked previously because all our inputs were all always tensors. In the seamless model we ran into a case where the inputs are a mixed tuple of tensors and constants (int's). In this case index `i` is not accurate anymore when accessing `input_tensors` to get the current tensor being operated on because we haven't pushed `i` number of tensors into the `input_tensors` vector as some of the inputs till now were non-tensors. Differential Revision: D54836802
tarun292
force-pushed
the
export-D54836802
branch
from
ce9f8ce to
ca02bb6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54836802 |
iseeyuan
approved these changes
Mar 13, 2024
|
This pull request has been merged in e98a7e0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In pybindings when iterating on the inputs, preparing them for execution we were using the index
ito access sizes, dim_order, strides etc. of the current tensor being iterated on. This worked previously because all our inputs were all always tensors.In the seamless model we ran into a case where the inputs are a mixed tuple of tensors and constants (int's). In this case index
iis not accurate anymore when accessinginput_tensorsto get the current tensor being operated on because we haven't pushedinumber of tensors into theinput_tensorsvector as some of the inputs till now were non-tensors.Differential Revision: D54836802