Fix install_flatc.sh version checking #2402
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2402
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4f9d7fd with merge base 8084a74 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54863485 |
shoumikhin
approved these changes
Mar 13, 2024
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Instead of looking at the latest git tag, look at the contents of a file in the repo. The old logic broke when upstream released a new version, but we were still pinned to the old version. This was functionally harmless, but printed a misleading message to users. Reviewed By: shoumikhin Differential Revision: D54863485
|
This pull request was exported from Phabricator. Differential Revision: D54863485 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Instead of looking at the latest git tag, look at the contents of a file in the repo. The old logic broke when upstream released a new version, but we were still pinned to the old version. This was functionally harmless, but printed a misleading message to users. Reviewed By: shoumikhin Differential Revision: D54863485
|
This pull request was exported from Phabricator. Differential Revision: D54863485 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Mar 14, 2024
Summary: Instead of looking at the latest git tag, look at the contents of a file in the repo. The old logic broke when upstream released a new version, but we were still pinned to the old version. This was functionally harmless, but printed a misleading message to users. Reviewed By: shoumikhin Differential Revision: D54863485
|
This pull request was exported from Phabricator. Differential Revision: D54863485 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Mar 14, 2024
Summary: Instead of looking at the latest git tag, look at the contents of a file in the repo. The old logic broke when upstream released a new version, but we were still pinned to the old version. This was functionally harmless, but printed a misleading message to users. Reviewed By: shoumikhin Differential Revision: D54863485
|
This pull request was exported from Phabricator. Differential Revision: D54863485 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Mar 14, 2024
Summary: Instead of looking at the latest git tag, look at the contents of a file in the repo. The old logic broke when upstream released a new version, but we were still pinned to the old version. This was functionally harmless, but printed a misleading message to users. Reviewed By: shoumikhin Differential Revision: D54863485
|
This pull request was exported from Phabricator. Differential Revision: D54863485 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D54863485 |
Summary: Instead of looking at the latest git tag, look at the contents of a file in the repo. The old logic broke when upstream released a new version, but we were still pinned to the old version. This was functionally harmless, but printed a misleading message to users. Reviewed By: shoumikhin Differential Revision: D54863485
|
This pull request was exported from Phabricator. Differential Revision: D54863485 |
|
This pull request has been merged in 90f6fa4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Instead of looking at the latest git tag, look at the contents of a file in the repo.
The old logic broke when upstream released a new version, but we were still pinned to the old version.
This was functionally harmless, but printed a misleading message to users.
Differential Revision: D54863485