Skip to content

Bump transformers version to most recent #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bump transformers version to most recent #2428

wants to merge 1 commit into from

Conversation

iseeyuan
Copy link
Contributor

Differential Revision: D54900518

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 14, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2428

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3915690 with merge base e98a7e0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 14, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54900518

@facebook-github-bot
Bump transformers version to most recent
3915690 
Summary: It cause issues for packages that depend on transformers. I got one with Numpy ABI mismatch which is hard to trace.

Differential Revision: D54900518
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54900518

@iseeyuan iseeyuan requested a review from guangy10 March 14, 2024 14:59
@guangy10
Copy link
Contributor

guangy10 commented Mar 14, 2024 •
edited
Loading

@huydhn The failed test is irrelevant to this PR, and I've seen that test being flaky on Linux for a while, however, marking a test as unstable is not supported in ExecuTorch (#1759), what would be the way to disable the flaky test so that developers can move fast. We do need such a mechanism today because the merge rule is installed and running, and that flaky test is in the pull jobs.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 63a1fde.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guangy10 guangy10 guangy10 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iseeyuan @facebook-github-bot @guangy10