Skip to content

[ET-VK] Fix OSS build for Vulkan Delegate #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Mar 14, 2024

Stack from ghstack (oldest at bottom):

Context

Recent changes to the Vulkan backend and PyTorch Vulkan API requires that the CMake build for the Vulkan delegate be reworked. This PR updates the CMake rules for the Vulkan delegate and makes sure that the Vulkan delegate can build correctly.

Differential Revision: D54914149

@pytorch-bot pytorch-bot bot added ciflow/periodic module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ labels Mar 14, 2024
SS-JIA added a commit that referenced this pull request Mar 14, 2024
ghstack-source-id: ce38c0f
Pull Request resolved: #2434
Copy link

pytorch-bot bot commented Mar 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2434

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c97d0f8 with merge base 9b22596 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

pytorch-bot bot commented Mar 14, 2024

Warning: Unknown label ciflow/periodic.
Currently recognized labels are

  • ciflow/nightly
  • ciflow/trunk
  • ciflow/binaries
  • ciflow/binaries/all

Please add the new label to .github/pytorch-probot.yml

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 14, 2024
@SS-JIA
Copy link
Contributor Author

SS-JIA commented Mar 14, 2024

@SS-JIA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SS-JIA merged this pull request in 1647cd0.

@SS-JIA SS-JIA deleted the gh/SS-JIA/17/head branch January 24, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/periodic CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants